Skip to content

Conversation

@svrooij
Copy link
Contributor

@svrooij svrooij commented Nov 29, 2024

Pull Request

📖 Description

Fix the reload issue. The page that contains the grid scrolls to the top when the querystring is altered. It sees the changed URL as a new page and reloads the page.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@dvoituron
Copy link
Collaborator

Can you add a PR description to explain the reason of these changes?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Nov 29, 2024

This change does not fix the issue for me.

In the demo site I've added the SaveStateInUrl and SaveStatePrefix to the DataGridTypical example. After this, the page still jumps to the top when a sort is changed to another column

Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not fix the problem where a page scroll happens

@vnbaaij vnbaaij changed the title Fix datagrid page reload [Datagrid] Page reload issue when using SaveStateInUrl Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants