-
Notifications
You must be signed in to change notification settings - Fork 461
[DataGrid] Add UseMenuService parameter to override menu behavior #3862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 59.8%
|
dvoituron
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
FluentDataGridcomponent, developers can now use theUseMenuServiceparameter to override the default menu behavior. When the parameter is set to true (default), andHeaderCellAsButtonWithMenuis true as well, it is hard to get focus on the shown menu with the keyboard. This is because the menu is then actually being rendered at a different location in the generated HTML.By offering the
UseMenuServiceparameter, developers can now choose to have the menu be generated inline in the grid's HTML which allows for the menu to be set focus to by keyboard.From an a11y standpoint we would advise to use the
UseMenuService="false"setting. However, we do not want to change the current behavior so we are not changing the default value of the parameter. Also, please be aware that after setting the parameter to false the menus are still being rendered on screen and do not get positioned behing other UI elements (which is what using the menu service and provider normally take car off)Fix #3810