Skip to content

Conversation

@miguelhasse
Copy link
Contributor

Pull Request

📖 Description

This pull request provides fixes/enhancements to the DataGrid component:

  • Fixed async 'Loading' state flag feedback, making sure data is not refreshed unnecessarily.
  • Fixed Virtual mode switch render handling, making sure data is correctly refreshed when deactivated

👩‍💻 Reviewer Notes

A working samples can be seen in the following repository projects:

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

@vnbaaij
Copy link
Collaborator

vnbaaij commented Nov 22, 2025

Have you also tested that the DataGrid still functions normally when not using the adapters? Like with the samples in the demo site itself?

I think we need to do that before merging this in. If needed, I can do this.

@miguelhasse
Copy link
Contributor Author

miguelhasse commented Nov 22, 2025

@vnbaaij I ran all the demo app scenarios for testing. All good!
You can further test using the apps I've provided above :)

@vnbaaij vnbaaij merged commit 13fac20 into microsoft:dev Nov 22, 2025
2 of 3 checks passed
@vnbaaij vnbaaij added this to the v4.13.2 milestone Nov 22, 2025
vnbaaij added a commit that referenced this pull request Nov 25, 2025
…#4349)

* Port #4343  Asynchronous IQueryable based loading enhancements to v5

* Failing tests with IServiceProvider. Go back to yusing non-async Dispose

* Process PR comment

---------

Co-authored-by: Denis Voituron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants