Skip to content

feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm #29616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 23, 2023

Pre-requirement

Previous Behavior

New Behavior

updates v9 and v8 migration generator to replace npmignore with package.json#files

Related Issue(s)

@Hotell Hotell changed the title Hotell/npm config updates feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm Oct 23, 2023
@Hotell Hotell force-pushed the hotell/npm-config-updates branch from fcd0c16 to a5342c6 Compare October 23, 2023 12:51
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023

📊 Bundle size report

🤖 This report was generated against 4c36df0e2a7bf9d54d5137fabe74c720bdddebbc

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 01bbda4:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 23, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4c36df0e2a7bf9d54d5137fabe74c720bdddebbc (build)

@Hotell Hotell marked this pull request as ready for review October 23, 2023 14:20
@Hotell Hotell requested a review from a team as a code owner October 23, 2023 14:20
@Hotell Hotell added the Fluent UI react (v8) Issues about @fluentui/react (v8) label Oct 23, 2023
@Hotell Hotell merged commit 9c9c4db into microsoft:master Oct 25, 2023
@Hotell Hotell deleted the hotell/npm-config-updates branch October 25, 2023 16:14
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 26, 2023
* master:
  chore: migrate to nx 16.10 (microsoft#29617)
  fix(react-drawer): accessibility tweaks (microsoft#29627)
  Fixing few legend colors not visible in dark mode (microsoft#29652)
  applying package updates
  Fixing dark mode bug for xAxis for Vertical Stacked bar chart (microsoft#29427)
  chore: Refactor RadioGroup stories to use Field, and remove individual storybook page for Radio (microsoft#29268)
  docs: fix description of SelectInitialValue story (microsoft#26493)
  chore: fix specs location (microsoft#29642)
  feat(scripts-task): implement initial verify-packaging task (microsoft#29595)
  feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm (microsoft#29616)
  fix(workspace-plugin): fix storybook and vr-test issues wihtin prepare-initial-release generator (microsoft#29577)
  feat(react-breadcrumb): removed non-interactive item  (microsoft#29623)
  fix(react-motion): prevent from breaking the rule of hooks (microsoft#29628)
  fix(react-toast): invoke useCustomStyleHook_unstable() (microsoft#29632)
  feat: Deprecate Alert component (microsoft#29615)
  chore(react-infobutton, react-components): Deprecate InfoButton and InfoLabel from react-infobutton (microsoft#29605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants