Skip to content

Gvfs trace2 checkout and reset experiment #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jeffhostetler
Copy link

Add some temporary telemetry around checkout and reset to help identify performance problems.
These are marked with the "exp" category.

Copy link
Member

@kewillford kewillford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you need me to run any perf tests against these changes?

@jeffhostetler
Copy link
Author

@kewillford These changes are fairly harmless by themselves, so I'm not worried about a regression here. But if we want to try a perf run on your stock configuration, then we could look and see if there are any voids in my data -- or areas where I should add some additional tracing.

So, yeah. If you have time to do one that would be great! Thanks!

@kewillford
Copy link
Member

@jeffhostetler there were some build errors.

@jeffhostetler
Copy link
Author

@kewillford sorry about that. i just pushed a fixup to take care of the cast error on the mac side.

I've never seen the tag error before on the windows build. do you know what that is?

@kewillford
Copy link
Member

There needs to be a tag in the history for the build to know what version number to stamp. Usually something like v2.21.0.vfs.1.1 which I guess the Microsoft:tentative/vfs-2.21.0 branch doesn't have.

@jeffhostetler
Copy link
Author

@kewillford How should we proceed? Do we want to create a temporary tag for now and reference that?

@kewillford
Copy link
Member

@jeffhostetler yeah that will work for now.

@jeffhostetler jeffhostetler force-pushed the gvfs-trace2-checkout-experiment branch from b9451f7 to cab7dad Compare May 1, 2019 16:44
@jeffhostetler jeffhostetler merged commit e872b12 into microsoft:tentative/vfs-2.21.0 May 1, 2019
@jeffhostetler
Copy link
Author

@kewillford I merged this PR and it looks like a tag was automatically created.

dscho pushed a commit that referenced this pull request May 25, 2019
…iment

Gvfs trace2 checkout and reset experiment
dscho pushed a commit that referenced this pull request May 27, 2019
…iment

Gvfs trace2 checkout and reset experiment
dscho pushed a commit that referenced this pull request Jun 3, 2019
…iment

Gvfs trace2 checkout and reset experiment
dscho pushed a commit that referenced this pull request Jun 8, 2019
…iment

Gvfs trace2 checkout and reset experiment
derrickstolee added a commit to microsoft/VFSForGit that referenced this pull request Jun 12, 2019
Updates to v2.22.0.vfs.1 as discussed in  microsoft/git#140.

Includes these changes in microsoft/git:

* microsoft/git#133
* microsoft/git#139
* microsoft/git#141
* microsoft/git#143

Also, the `post-indexchanged` hook was renamed to `post-index-change` as it was upstreamed.
@jeffhostetler jeffhostetler deleted the gvfs-trace2-checkout-experiment branch October 20, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants