forked from git-for-windows/git
-
Notifications
You must be signed in to change notification settings - Fork 100
BRANCHES.md: Add explanation of branches and using forks #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7806 commits
Select commit
Hold shift + click to select a range
9a7ddc0
t7300: `git clean -dfx` must show an error with long paths
dscho 62915ce
mingw: support spawning programs containing spaces in their names
dscho ec05260
fscache: add key for GIT_TRACE_FSCACHE
jeffhostetler 530b8eb
fscache: remember not-found directories
jeffhostetler 8190caa
fscache: add a test for the dir-not-found optimization
dscho 9c5559b
mingw: ensure that core.longPaths is handled *always*
dscho d14e5aa
dir.c: make add_excludes aware of fscache during status
jeffhostetler eaf3956
add: use preload-index and fscache for performance
jeffhostetler c12ef2f
fscache: make fscache_enabled() public
jeffhostetler cedc1e0
dir.c: regression fix for add_excludes with fscache
jeffhostetler f89b620
fetch-pack.c: enable fscache for stats under .git/objects
b287ad8
checkout.c: enable fscache for checkout again
a7d5d11
Enable the filesystem cache (fscache) in refresh_index().
benpeart b944e77
Merge branch 'program-data-config'
dscho e811cb5
mingw: introduce code to detect whether we're inside a Windows container
ZCube c526207
mingw: when running in a Windows container, try to rename() harder
ZCube 7a47304
mingw: move the file_attr_to_st_mode() function definition
ZCube 4cde96b
mingw: Windows Docker volumes are *not* symbolic links
dscho 9cf38f3
status: carry the --no-lock-index option for backwards-compatibility
dscho 6605306
status: reinstate --show-ignored-directory as a deprecated option
dscho cf9bef9
status: verify that --show-ignored-directory prints a warning
dscho fcb2f9d
mingw: change core.fsyncObjectFiles = 1 by default
dscho d78ffaa
mingw: kill child processes in a gentler way
dscho 55abc1a
mingw: really handle SIGINT
dscho ab8ce43
mingw: demonstrate that all file handles are inherited by child proce…
dscho 7edf2d2
mingw: work around incorrect standard handles
dscho f07044f
Merge branch 'spawn-with-spaces'
dscho 533841b
mingw: spawned processes need to inherit only standard handles
dscho 0518afe
Merge branch 'program-data-config'
dscho 0b869d1
Merge pull request #1897 from piscisaureus/symlink-attr
dscho d0a3677
transport-helper: prefer Git's builtins over dashed form
dscho 0670f53
mingw: explicitly specify with which cmd to prefix the cmdline
dscho 5bbbc84
mingw: when path_lookup() failed, try BusyBox
dscho 6db8762
test-run-command: learn to run (parts of) the testsuite
dscho 8d59cae
test-lib: avoid unnecessary Perl invocation
dscho a7891ac
tests: replace mingw_test_cmp with a helper in C
dscho b2a90fd
test-tool: learn to act as a drop-in replacement for `iconv`
dscho 5adeb2e
tests(mingw): if `iconv` is unavailable, use `test-helper --iconv`
dscho 00db67f
tests: use t/diff-lib/* consistently
dscho 536aae6
gitattributes: mark .png files as binary
dscho b2eeb16
tests: move test PNGs into t/diff-lib/
dscho 9d6e2ff
tests: only override sort & find if there are usable ones in /usr/bin/
dscho 822386e
tests: use the correct path separator with BusyBox
dscho b6df125
mingw: only use Bash-ism `builtin pwd -W` when available
dscho 6433ebc
tests (mingw): remove Bash-specific pwd option
dscho 97b562b
test-lib: add BUSYBOX prerequisite
dscho db0fb82
t0021: use Windows path when appropriate
dscho dc0c367
t1300: mark all test cases with funny filenames as !MINGW
dscho 1a31105
t4124: avoid using "normal" diff mode
dscho efdb04f
t5003: use binary file from t/diff-lib/
dscho 5686584
t5003: skip `unzip -a` tests with BusyBox
dscho 00da44d
t5532: workaround for BusyBox on Windows
dscho f70e182
t5605: special-case hardlink test for BusyBox-w32
dscho 4c2274b
t5813: allow for $PWD to be a Windows path
dscho 71383c7
t7063: when running under BusyBox, avoid unsupported find option
dscho ee1158d
t9200: skip tests when $PWD contains a colon
dscho 1407d2f
t9350: skip ISO-8859-1 test when the environment is always-UTF-8
dscho 43b837a
mingw: add a Makefile target to copy test artifacts
dscho 8ecb406
mingw (git_terminal_prompt): work around BusyBox & WSL issues
dscho f3fc9fc
mingw (git_terminal_prompt): do fall back to CONIN$/CONOUT$ method
dscho d5d8030
mingw (git_terminal_prompt): turn on echo explictly
dscho 6739192
Add a Code of Conduct
dscho c9d3afc
CONTRIBUTING.md: add guide for first-time contributors
derrickstolee 2f82cdd
README.md: Add a Windows-specific preamble
dscho 9a2d815
Add an issue template
shiftkey 73fe6ac
Modify the GitHub Pull Request template (to reflect Git for Windows)
09b9181
.github: Add configuration for the Sentiment Bot
dscho 8f945d2
Document how $HOME is set on Windows
alejandro5042 6a9ad54
sha1-name.c: add `get_oidf()` which acts like `get_oid()`
ungps fbf4f6d
strbuf.c: add `strbuf_join_argv()`
ungps 41edcfa
stash: improve option parsing test coverage
klusark 3fe172d
t3903: modernize style
ungps 13b7a8e
stash: rename test cases to be more descriptive
ungps 2306034
stash: add tests for `git stash show` config
ungps 23f071b
stash: mention options in `show` synopsis
ungps 5c7c5dc
stash: convert apply to builtin
klusark 1393382
stash: convert drop and clear to builtin
klusark ade7490
stash: convert branch to builtin
klusark e2271f9
stash: convert pop to builtin
klusark eac6893
stash: convert list to builtin
ungps 7393592
stash: convert show to builtin
ungps e2e5b02
stash: convert store to builtin
ungps 78f8dbb
stash: convert create to builtin
ungps 27d51c5
stash: convert push to builtin
ungps 12ee120
stash: make push -q quiet
ungps 03c4ea1
stash: convert save to builtin
ungps 8c6af6c
stash: convert `stash--helper.c` into `stash.c`
ungps 75ef422
stash: optimize `get_untracked_files()` and `check_changes()`
ungps d7e7c7a
stash: replace all `write-tree` child processes with API calls
ungps 74fc81e
Add back the original, scripted `git stash`
dscho c82c409
stash: optionally use the scripted version again
dscho 65feab2
rebase: move `reset_head()` into a better spot
dscho ed5596b
rebase: avoid double reflog entry when switching branches
dscho 35d8b65
builtin rebase: call `git am` directly
dscho dba4358
Merge 'ps/stash-in-c'
dscho ef0a72e
Merge 'builtin-rebase--am'
dscho 04eed6a
Add back the original, scripted interactive rebase backend
dscho d9a5e30
non-builtin rebase: use non-builtin interactive backend
dscho ba0a77b
Merge branch 'make-builtin-stash-and-rebase-opt-ins'
dscho d01b278
t0001: fix on case-insensitive filesystems
dscho 6db792c
Merge branch 'ready-for-upstream'
dscho e9113df
Merge branch 'gitk-and-git-gui-patches'
dscho 1085e81
Merge branch 'msvc'
jeffhostetler f0a14e7
Merge branch 'visual-studio'
jeffhostetler a4acd7c
Merge branch 'fscache'
dscho dc2d604
Merge branch 'long-paths'
dscho 8102053
Merge branch 'msys2'
dscho 405b6a8
Merge branch 'kblees/kb/symlinks'
dscho 36adb85
Merge pull request #1897 from piscisaureus/symlink-attr
dscho 592b4a9
Merge branch 'program-data-config'
dscho 0692990
Merge pull request #305 from dscho/msysgit_issues_182
dscho a2975af
Merge branch 'clean-long-paths'
dscho 31d8440
Merge branch 'spawn-with-spaces'
dscho 4e5cb14
Merge pull request #994 from jeffhostetler/jeffhostetler/fscache_nfd
dscho 4b53397
Merge branch 'core-longpaths-everywhere'
dscho 968bdfd
Merge pull request #971 from jeffhostetler/jeffhostetler/add_preload_…
dscho cd673f0
Merge pull request #1344 from jeffhostetler/perf_add_excludes_with_fs…
dscho ba3dd8c
Merge pull request #1426 from atetubou/fetch_pack
dscho 9926f51
Merge pull request #1468 from atetubou/fscache_checkout_flush
dscho 4a5f17f
Merge pull request #1827 from benpeart/fscache_refresh_index
dscho 6b69250
Merge 'docker-volumes-are-no-symlinks'
dscho 9bbf3ff
Merge branch 'status-no-lock-index'
dscho f371bb2
Merge pull request #1354 from dscho/phase-out-show-ignored-directory-…
dscho a72b117
Merge branch 'fsync-object-files-always'
dscho 4268a9c
Merge pull request #1170 from dscho/mingw-kill-process
dscho fc791ae
Merge branch 'inherit-only-stdhandles'
dscho 1138dc2
Merge branch 'busybox-w32'
dscho ef66be4
Merge branch 'fix-terminal-prompt'
dscho 98a28b5
Merge 'readme' into HEAD
dscho 7784b9d
Merge 'builtin-stash-rebase-v3'
jamill 637f39d
Merge pull request #1859 from dscho/funny-cased-cwd
dscho 2160075
fscache: use FindFirstFileExW to avoid retrieving the short name
benpeart 364a814
status: disable and free fscache at the end of the status command
benpeart d499d08
fscache: add GIT_TEST_FSCACHE support
benpeart aae1e18
At the end of the add command, disable and free the fscache so that w…
benpeart bfbe537
fscache: add fscache hit statistics
benpeart ef63b3f
mem_pool: add GIT_TRACE_MEMPOOL support
benpeart 51fa7b9
fscache: fscache takes an initial size
benpeart 1c973df
fscache: update fscache to be thread specific instead of global
benpeart 4d0a394
fscache: teach fscache to use mempool
benpeart e986fe1
Merge pull request #1908 from benpeart/FindFirstFileEx-gfw
dscho f1a0a9c
Merge pull request #1909 from benpeart/free-fscache-after-status-gfw
dscho 0209632
Merge pull request #1911 from benpeart/git_test_fscache-gfw
dscho 5d0267b
Merge pull request #1914 from benpeart/free-fscache-after-add-gfw
dscho a7a949e
Merge pull request #1910 from benpeart/fscache_statistics-gfw
dscho fb2fe7f
Merge remote-tracking branch 'benpeart/fscache-per-thread-gfw'
dscho 52d7824
mingw: add a helper function to attach GDB to the current process
dscho 4cbcc02
mingw: remove obsolete IPv6-related code
tanushree27 5033536
fscache: make fscache_enable() thread safe
benpeart 842a845
fscache: teach fscache to use NtQueryDirectoryFile
benpeart 0265f6b
Merge pull request #1915 from dscho/open-in-gdb
dscho a750df8
Merge pull request #1900 from tanushree27/remove-ipv6-fallback
dscho d69faaa
mingw: fix CPU reporting in `git version --build-options`
dscho 5487204
Merge pull request #1934 from benpeart/fscache-thread-safe-enable-gfw
dscho a2e7571
Merge pull request #1937 from benpeart/fscache-NtQueryDirectoryFile-gfw
dscho 02bcbfc
mingw: use ANSI or Unicode functions explicitly
dscho f4d245d
Merge pull request #1958 from dscho/ansi-unicode
dscho e313ac7
http: add support selecting http version
fcharlie 6581cff
Merge pull request #1968 from dscho/http-version
dscho 9515583
fixup! stash: convert apply to builtin
dscho c7989fe
pager: fix order of atexit() calls
d18382f
reset --stdin: trim carriage return from the paths
4f86ed7
Merge 'gvfs-preamble' into HEAD
dscho 962c486
gvfs: start by adding the -gvfs suffix to the version
sanoursa dbe47e5
sparse-checkout: update files with a modify/delete conflict
2f03132
sparse-checkout: avoid writing entries with the skip-worktree bit
f7203f8
Fix reset when using the sparse-checkout feature.
7f99db2
fsck: use ERROR_MULTI_PACK_INDEX
derrickstolee ca75317
gvfs: ensure that the version is based on a GVFS tag
dscho 186c9da
gvfs: add a GVFS-specific header file
a6e94dd
gvfs: add the core.gvfs config setting
4ac26d8
gvfs: add the feature to skip writing the index' SHA-1
09be583
gvfs: add the feature that blobs may be missing
6a0e1ba
Add a new run_hook_argv() function
dscho ac7b245
gvfs: prevent files to be deleted outside the sparse checkout
940d6b0
gvfs: allow "virtualizing" objects
7b0b2e0
gvfs: optionally skip reachability checks/upload pack during fetch
ec72be5
Hydrate missing loose objects in check_and_freshen()
333e48f
gvfs: ensure all filters and EOL conversions are blocked
e2d9dad
gvfs: add global command pre and post hook procs
28d6fcf
Allow hooks to be run before setup_git_directory()
dscho 88245cc
gvfs: introduce pre/post command hooks
ce8f580
Add support for read-object as a background process to retrieve missi…
c60a6f5
t0400: verify that the hook is called correctly from a subdirectory
dscho 56d891c
sha1_file: when writing objects, skip the read_object_hook
dscho 9dafe07
Pass PID of git process to hooks.
alepauly 5c6d739
Merge 'read-object-hook' into HEAD
dscho 5ef0cf2
pre-command: always respect core.hooksPath
dscho d9dd272
Merge 'pre-post-command-hooks' into HEAD
dscho bf4b74b
Merge 'sparse-checkout-fixes' into HEAD
dscho fee970c
Do not remove files outside the sparse-checkout
c84dffd
gvfs: refactor loading the core.gvfs config value
bba9922
status: add status serialization mechanism
jeffhostetler 060001e
cache-tree: remove use of strbuf_addf in update_one
0814630
status: add status.aheadbehind setting
jeffhostetler d614310
Merge branch 'serialize_status_gvfs'
dscho 5c2879f
Teach ahead-behind and serialized status to play nicely together
jamill 2d89233
status: add warning when a/b calculation takes too long for long/norm…
jeffhostetler ed7391f
status: ignore status.aheadbehind in porcelain formats
jeffhostetler e0e928f
status: serialize to path
jeffhostetler 9680d7f
status: reject deserialize in V2 and conflicts
jeffhostetler 32d774f
fetch: Warn about forced updates after branch list
derrickstolee e6b90e1
fetch: Add --[no-]show-forced-updates argument
derrickstolee d43dec5
Merge branch 'ahead-behind-and-serialized-status'
dscho c452ae4
push: add --[no-]show-forced-updates passthrough to fetch
derrickstolee c6feda7
fetch: add documentation for --[no-]show-forced-updates
derrickstolee 9f52fe4
Merge branch 'show-forced-updates'
dscho c2ea892
Add virtual file system settings and hook proc
benpeart 48a26f5
Merge 'forced-updates-after-branch-list'
dscho df015a5
Update the virtualfilesystem support
benpeart ea9855f
Merge 'virtual-file-system-support'
dscho fa16bc0
commit: add generation to pop_most_recent_commit()
derrickstolee bbb9293
Merge 'update/virtual-file-system'
dscho 2926617
Merge 'gvfs/ds/generation-numbers-update'
dscho 52c31f5
status: fix rename reporting when using serialization cache
jeffhostetler 8a9cfa1
status: add comments for ahead_behind_flags in serialization
jeffhostetler 35fae6e
serialize-status: serialize global and repo-local exclude file metadata
jeffhostetler e669dbd
Merge pull request #6 from jeffhostetler/gvfs-serialize-status-rename
jeffhostetler b8a0906
status: deserialization wait
jeffhostetler aad187f
Merge pull request #1 from jeffhostetler/gvfs-serialize-exclude
jeffhostetler c6ed96e
virtualfilesystem: don't run the virtual file system hook if the inde…
benpeart 4bf9218
Merge pull request #7 from jeffhostetler/gvfs-status-serialize-wait
jeffhostetler 578ca43
virtualfilesystem: fix bug with symlinks being ignored
benpeart c208015
Merge pull request #15 from benpeart/difftool
benpeart d500192
Merge pull request #27 from benpeart/virtualprojectionlinks
benpeart 769724e
trace2: create new combined trace facility
jeffhostetler a9f708e
trace2: add trace2 tracing of major regions in wt-status
jeffhostetler e45bc60
trace2: classify some child processes
jeffhostetler f142a15
trace2: add child classification for transport processes
jeffhostetler 3af982f
trace2: instrument reading and writing the index
jeffhostetler 99ada13
gvfs:trace2: add region/data events for status deserialization
jeffhostetler f10c0d7
virtualfilesystem: check if directory is included
3a564fa
gvfs:trace2: add trace2 tracing around read_object_process
jeffhostetler b0c591a
Merge pull request #33 virtualfilesystem - check if directory is incl…
d8b6284
pack-objects: add trace2 regions
derrickstolee 68fb1f2
Merge pull request #28 from jeffhostetler/gvfs-trace2-v1
jeffhostetler cf4c1ae
Merge pull request #34 Add Trace2 regions to 'pack-objects'
derrickstolee 7709e5e
rebase/stash: make post-command hook work again
dscho f7f0dbc
read-cache: add post-indexchanged hook
benpeart 6f11ade
read-cache: post-indexchanged hook add skip-worktree bit changing sup…
benpeart 77eefa1
Merge pull request #36 Avoid `sane_execvp` in `git rebase` and `git s…
derrickstolee 984275e
read-cache: add test for post-indexchanged hook
benpeart 4e8852f
send-pack: do not check for sha1 file when GVFS_MISSING_OK set
c5b4b4c
Merge pull request #24 Match multi-pack-index feature from upstream
dscho 886eddb
Add documentation for the post-indexchanged hook
09e3b51
Merge pull request #68 send-pack do not check for sha1 file when GVFS…
d5866d6
vfs: fix case where directories not handled correctly
jamill 376b902
Merge pull request #64 Index changed hook
db2e92b
Merge pull request #70 from jamill/jamill/virtual_filesystem_directories
jamill ebb10b5
BRANCHES.md: Add explanation of branches and using forks
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
[*] | ||
charset = utf-8 | ||
insert_final_newline = true | ||
|
||
# The settings for C (*.c and *.h) files are mirrored in .clang-format. Keep | ||
# them in sync. | ||
[*.{c,h,sh,perl,pl,pm}] | ||
indent_style = tab | ||
tab_width = 8 | ||
|
||
[*.py] | ||
indent_style = space | ||
indent_size = 4 | ||
|
||
[COMMIT_EDITMSG] | ||
max_line_length = 72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
Branches used in this repo | ||
========================== | ||
|
||
The document explains the branching structure that we are using in the git for VFSForGit repository as well as the forking strategy that we have adopted for contributing. | ||
|
||
Repo Branches | ||
------------- | ||
|
||
1. master | ||
|
||
This will track the git for windows repository master branch | ||
kewillford marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
2. vfs | ||
|
||
Would like to use this branch as an ever-green branch that continually rebases the VFSForGit changes onto a windows ever-green branch that is on the core/master, so that we can detect when the patches for VFSForGit have issues or if we have a new version patches sent upstream git we can regenerate this branch. | ||
|
||
3. vs/master | ||
|
||
This tracks with the git for windows repository vs/master branch and are the generated files for using a Visual Studio solution. | ||
|
||
4. vfs-# | ||
|
||
These branches are used to track the specific version that match git for windows with the VFSForGit specific patches on top. When a new version of git for windows is released, the VFSForGit patches will be rebased on that windows version and a new gvfs-# branch created to create pull requests against. | ||
|
||
#### Examples | ||
``` | ||
vfs-2.20.0 | ||
vfs-2.20.1 | ||
``` | ||
|
||
The versions of git for VFSForGit are based on the git for windows versions. v2.20.0.vfs.1 will correspond with the v2.20.0.windows.1 with the VFSForGit specific patches applied to the windows version. | ||
|
||
Tags | ||
---- | ||
|
||
We are using annotated tags to build the version number for git. The build will look back through the commit history to find the first tag matching `v[0-9]*vfs*` and build the git version number using that tag. | ||
|
||
Forking | ||
------- | ||
|
||
A personal fork of this repository and a branch in that repository should be used for development. | ||
|
||
These branches should be based on the latest vfs-# branch. If there are work in progress pull requests that you have based on a previous version branch when a new version branch is created, you will need to move your patches to the new branch to get them in that latest version. | ||
|
||
#### Example | ||
``` | ||
git clone <personal fork repo URL> | ||
git remote add ms https://github.com/Microsoft/git.git | ||
git checkout -b my-changes ms/vfs-2.20.0 --no-track | ||
git push -fu origin HEAD | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -418,3 +418,10 @@ potentially interested reviewers. | |
``` | ||
git send-email [email protected] --cc=<email1> --cc=<email2> [dir with patches]/*.patch | ||
``` | ||
|
||
To submit a nth version patch (say version 3): | ||
|
||
``` | ||
git send-email [email protected] --cc=<email1> --cc=<email2> \ | ||
--in-reply-to=<the message id of cover letter of patch v2> [dir with patches]/*.patch | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,3 +12,4 @@ cmds-*.txt | |
mergetools-*.txt | ||
manpage-base-url.xsl | ||
SubmittingPatches.txt | ||
tmp-doc-diff/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.