Skip to content

multi-pack-index: add --no-progress to verify #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

multi-pack-index: add --no-progress to verify #186

merged 1 commit into from
Sep 10, 2019

Conversation

wilbaker
Copy link
Member

@wilbaker wilbaker commented Aug 26, 2019 •
edited
Loading

These changes are a port of gitgitgadget#315 to the multi-pack-index command.

wilbaker
wilbaker commented Aug 26, 2019
View reviewed changes
wilbaker
wilbaker commented Aug 26, 2019
View reviewed changes
garimasi514
garimasi514 reviewed Aug 27, 2019
View reviewed changes
derrickstolee
derrickstolee approved these changes Aug 27, 2019
View reviewed changes
Copy link

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a suggestion to add tests as in @garimasi514's series. Code looks good to me.

jeffhostetler
jeffhostetler reviewed Sep 9, 2019
View reviewed changes
jeffhostetler
jeffhostetler approved these changes Sep 9, 2019
View reviewed changes
Copy link

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. a few minor nits.

@wilbaker wilbaker force-pushed the multi-pack-index-progress-toggle_v-2.23.0 branch from 3390f88 to 7234327 Compare September 10, 2019 00:18
@wilbaker
Copy link
Member Author

@derrickstolee @jeffhostetler @garimasi514

I've just pushed a new commit that address all of the feedback so far and updates the multi-pack-index tests.

Please let me know if you have any feedback on the latest changes, especially when it comes to the changes I've made to the tests.

wilbaker
wilbaker commented Sep 10, 2019
View reviewed changes
@wilbaker
Copy link
Member Author

@derrickstolee if these changes look good to you, let me know if you'd like me to merge this PR into microsoft:vfs-2.23.0 now, or if there there is another process I should be following for fast-tracking the changes into https://github.com/microsoft/git

derrickstolee
derrickstolee approved these changes Sep 10, 2019
View reviewed changes
Copy link

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestions. We should take this into our branch early, but also send this upstream soon.

@wilbaker wilbaker mentioned this pull request Sep 10, 2019
Merged
garimasi514
garimasi514 reviewed Sep 10, 2019
View reviewed changes
@derrickstolee
Copy link

/azp run git - build installers

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@wilbaker wilbaker force-pushed the multi-pack-index-progress-toggle_v-2.23.0 branch from 7234327 to deb9896 Compare September 10, 2019 15:28
@wilbaker wilbaker changed the title [WIP/RFC] multi-pack-index: add --no-progress to verify multi-pack-index: add --no-progress to verify Sep 10, 2019
@wilbaker wilbaker mentioned this pull request Sep 10, 2019
Merged
@wilbaker
Copy link
Member Author

/azp run Microsoft.git (linux-gcc)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@wilbaker wilbaker closed this Sep 10, 2019
@wilbaker wilbaker reopened this Sep 10, 2019
@wilbaker
multi-pack-index: add --no-progress to verify
0dbe390 
Add --no-progress option to git multi-pack-index.
The progress feature was added in 144d703
("multi-pack-index: report progress during 'verify'", 2018-09-13)
but the ability to opt-out was overlooked.

Signed-off-by: William Baker <[email protected]>
@wilbaker wilbaker force-pushed the multi-pack-index-progress-toggle_v-2.23.0 branch from deb9896 to 0dbe390 Compare September 10, 2019 17:32
@wilbaker wilbaker merged commit 36b7a32 into microsoft:vfs-2.23.0 Sep 10, 2019
@wilbaker wilbaker mentioned this pull request Sep 10, 2019
Merged
derrickstolee pushed a commit that referenced this pull request Oct 25, 2019
@wilbaker @derrickstolee
Merge pull request #186 multi-pack-index: add --no-progress to verify
3ab221e 
multi-pack-index: add --no-progress to verify
derrickstolee pushed a commit that referenced this pull request Nov 4, 2019
@wilbaker @derrickstolee
Merge pull request #186 multi-pack-index: add --no-progress to verify
8f72595 
multi-pack-index: add --no-progress to verify
@wilbaker wilbaker mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garimasi514 garimasi514 garimasi514 left review comments

@derrickstolee derrickstolee derrickstolee approved these changes

@jeffhostetler jeffhostetler jeffhostetler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilbaker @derrickstolee @jeffhostetler @garimasi514