Index changed hook #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpeart
reviewed
Oct 30, 2018
benpeart
approved these changes
Oct 30, 2018
builtin/reset.c
Outdated
| refresh_index(&the_index, flags, NULL, NULL, | ||
| _("Unstaged changes after reset:")); | ||
| the_index.reset_mixed = 1; |
There was a problem hiding this comment.
Is this going to start colliding with Duy's work to remove the_index everywhere? Is there something we can do now to prepare for that coming from upstream?
There was a problem hiding this comment.
I'm sure it will but he would need to change the refresh_index method above as well so at that point we can just create the fixup commit to fix our use of the_index as well.
kewillford
force-pushed
the
index-changed-hook
branch
2 times, most recently
from
246331a to
b94da14
Compare
kewillford
force-pushed
the
index-changed-hook
branch
from
b94da14 to
e44b85b
Compare
kewillford
force-pushed
the
index-changed-hook
branch
2 times, most recently
from
3fbae71 to
979653d
Compare
derrickstolee
approved these changes
Nov 12, 2018
kewillford
force-pushed
the
index-changed-hook
branch
from
979653d to
12b8b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a post index changed hook that VFSForGit will be able to use to detect when it needs to update it's projection of files.