Skip to content

Conversation

shueybubbles
Copy link
Collaborator

Fixes #214

  • Iteration 1 adds a basic linter skeleton with one linter that flags use of non-assert test failure methods like t.Fatalf
  • Adds use of the linter to build\build.cmd to print out any warnings. Once we are clean we can convert the linter run to a step in the PR validation pipeline.
  • Iteration 2 will add enforcement of package import/hierarchy rules.

@shueybubbles shueybubbles marked this pull request as ready for review March 2, 2023 15:13
Copy link
Collaborator

@stuartpa stuartpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shueybubbles shueybubbles merged commit d479b3d into main Mar 8, 2023
@shueybubbles shueybubbles deleted the shueybubbles/267 branch March 8, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce use of assert.Equalf(t, ...) pattern instead of if != then { t.Errorf(...) } pattern
2 participants