Skip to content

[microsoft/dev.boringcrypto.go1.18] gate openssl backend behind cgo build constraint #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Mar 24, 2022

go-crypto-openssl should not be used when cgo is disabled, as OpenSSL bindings require cgo.

This PR gates the OpenSSL backend behind the cgo build constraint so it is only used when building with CGO_ENABLED=1.

Updates #492

@qmuntal qmuntal requested a review from a team as a code owner March 24, 2022 08:24
@qmuntal qmuntal requested a review from a user March 24, 2022 08:24
@dagood dagood merged commit 0f7b5eb into microsoft/dev.boringcrypto.go1.18 Mar 29, 2022
@dagood dagood deleted the dev/qmuntal/openssl-cgo-go1.18 branch March 29, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants