Skip to content

Update submodule to latest master in microsoft/main #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Mar 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2023

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

@ghost ghost self-requested a review as a code owner February 13, 2023 16:01
@ghost ghost self-requested a review February 13, 2023 16:01
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Auto-approving.

@ghost ghost enabled auto-merge February 13, 2023 16:01
@ghost ghost force-pushed the dev/auto-sync/microsoft/main branch 4 times, most recently from 893428b to fd4f139 Compare February 22, 2023 16:02
@ghost ghost force-pushed the dev/auto-sync/microsoft/main branch 3 times, most recently from f1ede6a to e2d21d3 Compare March 1, 2023 16:07
@qmuntal
Copy link
Member

qmuntal commented Mar 3, 2023

The Windows pipelines are failing due to TestGdbPanic. I've sent an upstream fix for that: https://go-review.googlesource.com/c/go/+/473116.

We caught this issue because our builders have gdb installed, while upstream doesn't. IMO it makes sense to keep gdb, as hopefully upstream will install it in the near future: golang/go#22021.

@ghost ghost force-pushed the dev/auto-sync/microsoft/main branch from c244632 to 85ac595 Compare March 3, 2023 16:02
@qmuntal
Copy link
Member

qmuntal commented Mar 6, 2023

There is another test failing, this time because our Windows builders have pkg-config but upstream don't, and there is a bug in how Go handles pkg-config flags. I just submitted a issue for that: golang/go#58889. Working on the fix.

@ghost ghost force-pushed the dev/auto-sync/microsoft/main branch from f13c034 to 3ab0cc7 Compare March 6, 2023 16:02
@ghost ghost force-pushed the dev/auto-sync/microsoft/main branch from 3ab0cc7 to 1f4fa76 Compare March 8, 2023 16:04
@ghost ghost merged commit f687b92 into microsoft/main Mar 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant