Support lazy loading object values from toString() #401
Conversation
...ore/src/main/java/com/microsoft/java/debug/core/adapter/handler/VariablesRequestHandler.java
Outdated
Show resolved
Hide resolved
| @@ -94,6 +95,24 @@ | |||
| } | |||
|
|
|||
| VariableProxy containerNode = (VariableProxy) container; | |||
|
|
|||
| if (containerNode.getReferencedVariableId() != null && DebugSettings.getCurrent().showToString) { | |||
There was a problem hiding this comment.
I'd suggest to extract the following block to a private method like resolveLazyValue(variable) for more readable.
....debug.core/src/main/java/com/microsoft/java/debug/core/adapter/variables/VariableProxy.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/com/microsoft/java/debug/core/adapter/handler/VariablesRequestHandler.java
Outdated
Show resolved
Hide resolved
| String valueString = variableFormatter.valueToString(variable, options); | ||
| String detailString = VariableDetailUtils.formatDetailsValue(variable, containerNode.getThread(), variableFormatter, options, | ||
| evaluationEngine); | ||
| return new Types.Variable("", valueString + " " + detailString, "", referenceId, ""); |
There was a problem hiding this comment.
When running it on an old vscode, you will find variable name info is missing.
|
Is it somehow possible to disable this? I now have to do a lot of clicks to view the desired information during debugging... |
|
@beckermarc you can set configuration |
|
Thanks. However that seems to disable the whole feature. I'd prefer to only disable the lazy loading. Is that also possible? |
@testforstephen any comments? |
|
Make sense to have a setting to turn it off. |
|
I think my main concern with this change is that it also seems to hide more information than just the toString() value: Here is one example before the version that introduced this change: Here is the same variable with the new version. Note that I also don't see the class anymore and are no longer made aware of the fact that I can expand this variable further: After clicking the ellipsis I get the same information as before: Especially when trying to get an overview over all variables in the current scope this requires me to do a lot more clicks. I never ran into issues with long running toString() methods in my projects so far, so it would be great to be able to disable this from my perspective. |
|
yes, it would be better to display the class name during lazy loading. This is an improvement we also reported back to VS Code core team. microsoft/vscode#135147 (comment) |
|
cool, thanks for your work! |
|
Please include an option to disable the lazy loading and return to the old method of displaying variable values. With this addition debugging has become very painful. |
|
VS Code has added a setting |
|
FYI. The latest VS Code 1.67.0 has provided a setting |
requires: microsoft/vscode-java-debug#1134
specification: https://microsoft.github.io/debug-adapter-protocol/specification#Types_VariablePresentationHint
demo:
more details can be found in microsoft/vscode#135147, and there is still a UX discussion.