Skip to content

Send logpoint messages to the debug console #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sbj42
Copy link
Contributor

@sbj42 sbj42 commented Mar 16, 2022

This change sends logpoint messages as protocol events to the vscode-java-debug extension, instead of printing them to System.out of the process being debugged.

Fixes microsoft/vscode-java-debug#710

Instead of printing them to `System.out` of the process being debugged.
This should be paired with a change in vscode-java-debug to receive
the message and send it to the vscode debug console.
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to send logpoint to debug console. A suggestion is to use standard OutputEvent to send the logpoint to client.

Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@testforstephen testforstephen merged commit 798d259 into microsoft:main Mar 23, 2022
@testforstephen
Copy link
Contributor

@sbj42 thanks for the contribution.

@sbj42 sbj42 deleted the sbj42/logpoint-log-to-debug-console branch March 23, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output logpoints to debug console
2 participants