Update to new Microsoft cookie banner #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatten
reviewed
Oct 12, 2020
|
|
||
| // Where we would handle non-essential cookies in the future | ||
| } | ||
|
|
||
| $(function() { | ||
| // Load GA upfront because we classify it as essential cookie |
There was a problem hiding this comment.
what makes this an essential cookie?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only cookie currently is the GA essential cookie so we don't need to do any conditional creation or disabling.
This PR just updates the cookie banner and adds the "Manage cookies" link to the footer.