[Femi Adeyemi (femiatl)]

1. Replace HOST_LOGGER with CRASH_LOGGER. It logs to VTL1 allocated
   memory and mirrors to the serial port, only dumping to the VTL0
   ringbuffer on a panic. This replaces HOST_LOGGER writing to serial
   port and the VTL0 ringbugffer. When a crash dump key is set,
   release builds will turn serial mirroring off.

2. VTL0 uses a new SetCrashDumpKey API to send LiteBox a public key
   for crash dump envelope encryption. Key verification is a TODO, so
   this API must be called before EndofBoot flag is set. Only DER
   encoded RSA-(2048,3072,4096 bit) keys are supported.

3. On panic, VTL1 logs are encrypted in place with a symmetric key
   (AES-256-GCM), and that key is wrapped by the public key sent
   via SetCrashDumpKey API. The crash dump envelope is then written to
   VTL0 ringbuffer in the following format:
   CrashDumpHeader | Wrapped Key | Log Ciphertext | Tag

4. The panic path uses locks with bounded wait times and avoids
   allocation. Writes to VTL0 wingbuffer are the exception. TODOs have
   been added to simplify that path.

Signed-off-by: Femi Adeyemi femiadeyemi@microsoft.com

[Copilot]

🟡 Changes recommended

Unresolved provisioning, log retention, serialization, key-trust, and panic-coordination issues prevent reliable and secure crash dumping.

8 open issues

• Advance ring buffer head only for overwritten bytes · New
• Park concurrent panics during crash dump collection · New
• Remove duplicate crash dump key ID · New
• Reject dump key provisioning after boot trust window · New
• Route SetCrashDumpKey dispatch to the gate method · New
• Include panic information in encrypted crash artifact · New
• Preserve formatted prefix for oversized records · New
• Use the CRNG-produced seed for dump key generation · New

What changed in this PR

This PR introduces encrypted crash logging for LVBS, keeping logs in VTL1 memory and preparing an encrypted envelope for export to VTL0 on panic.

Changes:

• Replaces the host logger with a fixed-size crash logger and optional debug serial mirroring.
• Adds crash-dump key provisioning interfaces and RSA-wrapped AES-256-GCM encryption.
• Connects panic handling to dump generation and updates dependencies and global-count limits.

File	Description
litebox_runner_lvbs/​src/​main.rs	Installs the crash logger and configures serial mirroring.
litebox_runner_lvbs/​src/​lib.rs	Adds the dispatch arm and invokes dumping on panic.
litebox_platform_lvbs/​src/​mshv/​vsm.rs	Implements public-key loading and envelope preparation.
litebox_platform_lvbs/​src/​mshv/​ringbuffer.rs	Adds a TODO about buffer alignment requirements.
litebox_platform_lvbs/​src/​lib.rs	Exposes the crash-log module.
litebox_platform_lvbs/​src/​host/​lvbs_impl.rs	Makes the hardware seed helper crate-visible.
litebox_platform_lvbs/​src/​crash_log.rs	Implements buffered logging, encryption, and dump serialization.
litebox_platform_lvbs/​src/​arch/​x86/​ioport.rs	Removes ring-buffer forwarding and adds nonblocking panic serial output.
litebox_platform_lvbs/​Cargo.toml	Adds logging and encryption dependencies.
litebox_common_lvbs/​src/​lib.rs	Defines the crash-key call, gate method, and error.
dev_tests/​src/​ratchet.rs	Adjusts global-count limits for logger relocation.
Cargo.lock	Records the added cryptographic dependency graph.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved critical defects can make crash logging fail or hang, retain an unsafe buffer registration, and panic during key setup, while a missing fixture prevents test compilation.

4 open issues

• Prepare allocation-free crash-log writes before panic · New
• Add the missing DER fixture required to compile the test · New
• Return an error when the platform root key is not initialized · New
• Publish the ring buffer only after frame protection succeeds · New

8 resolved since last review

• Route SetCrashDumpKey dispatch to the gate method
• Reject dump key provisioning after boot trust window
• Remove duplicate crash dump key ID
• Park concurrent panics during crash dump collection
• Advance ring buffer head only for overwritten bytes
• Use the CRNG-produced seed for dump key generation
• Preserve formatted prefix for oversized records
• Include panic information in encrypted crash artifact

_{Review effort: Balanced}

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_variant_added.ron

Failed in:
  variant VsmFunction:SetCrashDumpKey in /home/runner/work/litebox/litebox/litebox_common_lvbs/src/lib.rs:86
  variant VsmFunction:RunLvbsTest in /home/runner/work/litebox/litebox/litebox_common_lvbs/src/lib.rs:87

--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_added.ron

Failed in:
  trait method litebox_common_lvbs::Vtl1Gate::set_crash_dump_key in file /home/runner/work/litebox/litebox/litebox_common_lvbs/src/lib.rs:919

--- failure trait_method_return_value_added: pub trait method return value added ---

Description:
A trait method that previously returned `()` now returns a value. Since the trait is not sealed, downstream implementations of the trait will get compile errors.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_return_value_added.ron

Failed in:
  litebox_common_lvbs::Vtl0Gate::install_ringbuffer in file /home/runner/work/litebox/litebox/litebox_common_lvbs/src/lib.rs:826