Repository navigation
Prepare broker file systems for multiple containers - #1831
Closed
Weidong Cui (wdcui) wants to merge 2 commits into
Closed
Weidong Cui (wdcui) wants to merge 2 commits into
Weidong Cui (wdcui) wants to merge 2 commits into
Conversation
Composers built from shared allocators never share a device, including for their virtual directories, so file systems built for different containers never share a node identity. A backend in an Arc can be mounted by several file systems, as a shared volume. An open file keeps the file service that opened it, so it works the same in any process. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f5406de6-bab4-4f3b-b232-ae238032c2c2
Both socket tests fail only when the node identity test does. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f5406de6-bab4-4f3b-b232-ae238032c2c2
Weidong Cui (wdcui)
force-pushed
the
wdcui/ulitebox/container-fs
branch
from
November 10, 2026 04:45
f90c8f7 to
b83801a
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Member
Author
|
Superseded by #1837, which folds in what the mount trees need from this PR (composers sharing inode allocators) and replaces "open files keep their service" with open files keeping the mount that opened them. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the broker core's file systems for running several containers in one broker.
Composer::builder_withbuilds composers from shared allocators, so no two of them share a device, including for virtual directories, and file systems built for different containers never share a node identity. AnArcof a backend is a backend, so file systems can share a volume, and an open file keeps the file service that opened it.