Repository navigation
CI improvements - #418
Merged
Jay Bosamiya (Microsoft) (jaybosamiya-ms) merged 5 commits intoOct 15, 2025
Merged
CI improvements#418
Conversation
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/ci-improvements
branch
8 times, most recently
from
October 15, 2025 00:41
dfda936 to
c7370b9
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
marked this pull request as ready for review
October 15, 2025 00:41
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
requested a review
from Weidong Cui (wdcui)
October 15, 2025 00:42
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
enabled auto-merge
October 15, 2025 00:42
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
disabled auto-merge
October 15, 2025 00:50
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/ci-improvements
branch
2 times, most recently
from
October 15, 2025 01:03
204de90 to
eb9cc83
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/ci-improvements
branch
from
October 15, 2025 01:04
eb9cc83 to
5be47c5
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
enabled auto-merge
October 15, 2025 01:45
Weidong Cui (wdcui)
approved these changes
Oct 15, 2025
Weidong Cui (wdcui)
left a comment
Member
There was a problem hiding this comment.
LGTM. Thank you, Jay!
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
deleted the
jayb/ci-improvements
branch
October 15, 2025 03:14
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
added a commit
that referenced
this pull request
Oct 7, 2026
This PR makes a few small QoL improvements to the CI: 1. If you push a new commit while there are ongoing checks, it will cancel the old ones. Saves some CI time. Does mean you can get a cancellation notification, but that is at least separate from a failure notification (which at least makes me take a look at why it failed, before I realize "oh, I had pushed a new commit that fixed this already"). 2. We already have caches for build dependencies but these caches explicitly don't store "intermediate" state. Our custom caching (#363) that works really well locally gets blasted away on the CI, which means we are spending a whole bunch of time on the CI simply re-doing the same things on every run, making results take longer. I've now updated the CI build to keep track of such artifacts, so that builds are faster. Basically, our builds should be ~6 minutes faster on the CI (the semver-checks and codeql is still the bottleneck, but those ones are less "problematic" in terms of getting quick feedback) 3. Make the CI assert that `Cargo.lock` will remain unchanged upon building (i.e., confirm it is up to date). This also updates our `Cargo.lock` to include a couple of missing lines. 4. Make the CI resistant to the mild flakiness that shows up sometimes on the LVBS runs by allowing up to two retries. This does not change anything locally (so flakiness is _intentionally_ still apparent locally), but only on the CI where the flakiness is currently folks effectively are simply re-running the CI for that flakiness already. 5. Set up a hard 10-minute timeout per test; this is to account for tests where something causes them to run too long. Ideally, we'd set this to a smaller number, but at least a 10-minute limit means that we won't have things running until someone manually notices that it has been running too long or some other limits kick in.
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few small QoL improvements to the CI:
Cargo.lockwill remain unchanged upon building (i.e., confirm it is up to date). This also updates ourCargo.lockto include a couple of missing lines.