Skip to content

Expanded Python test + faster caching - #687

Merged
Jay Bosamiya (Microsoft) (jaybosamiya-ms) merged 3 commits into
mainfrom
jayb/python3121-fixup
Mar 2, 2026
Merged

Jay Bosamiya (Microsoft) (jaybosamiya-ms) merged 3 commits into
mainfrom
jayb/python3121-fixup

Conversation

@jaybosamiya-ms

@jaybosamiya-ms Jay Bosamiya (Microsoft) (jaybosamiya-ms) commented Feb 26, 2026 •

Copy link
Copy Markdown
Member

This PR has two somewhat related changes I hit when running the Python test. Some versions of Python (concretely, 3.12.1) require more files to be pulled in than were being pulled in before; the first commit in this PR fixes this. The second commit speeds the cache up by just using mtime+size rather than spending a bunch of time on computing sha256.

@jaybosamiya-ms
Jay Bosamiya (Microsoft) (jaybosamiya-ms) marked this pull request as ready for review February 26, 2026 03:26
@jaybosamiya-ms

Jay Bosamiya (Microsoft) (jaybosamiya-ms) commented Feb 26, 2026 •

Copy link
Copy Markdown
Member Author

Note: the sha256 change shifts one bottleneck to further along the pipeline for the particular environment I am running this in, but I will leave those changes to a separate PR when I get some more cycles.

@wdcui Weidong Cui (wdcui) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left one comment below.

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown

🤖 SemverChecks 🤖 No breaking API changes detected

Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered.

Merged via the queue into main with commit fec3113 Mar 2, 2026
14 checks passed
@jaybosamiya-ms
Jay Bosamiya (Microsoft) (jaybosamiya-ms) deleted the jayb/python3121-fixup branch March 2, 2026 22:18
Jay Bosamiya (Microsoft) (jaybosamiya-ms) added a commit that referenced this pull request Oct 7, 2026
This PR has two somewhat related changes I hit when running the Python
test. Some versions of Python (concretely, 3.12.1) require more files to
be pulled in than were being pulled in before; the first commit in this
PR fixes this. The second commit speeds the cache up by just using
mtime+size rather than spending a bunch of time on computing sha256.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants