Skip to content

Fix for issue reported via mypy#118

Merged
karthiknadig merged 3 commits into
microsoft:mainfrom
karthiknadig:mypy
Nov 4, 2022
Merged

Fix for issue reported via mypy#118
karthiknadig merged 3 commits into
microsoft:mainfrom
karthiknadig:mypy

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

@karthiknadig karthiknadig commented Nov 3, 2022 •
edited
Loading

Closes #96

  1. Fixes issues reported via mypy --strict lsprotocol
  2. Adds py.typed to the package indicating that the package is typed.
  3. Adds mypy to the linting step.

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Nov 3, 2022
@karthiknadig karthiknadig self-assigned this Nov 3, 2022
@karthiknadig karthiknadig marked this pull request as ready for review November 3, 2022 20:31
@karthiknadig karthiknadig enabled auto-merge (squash) November 4, 2022 05:47
@karthiknadig karthiknadig merged commit d83ff38 into microsoft:main Nov 4, 2022
@karthiknadig karthiknadig deleted the mypy branch January 10, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eleanorjboyd eleanorjboyd Awaiting requested review from eleanorjboyd

1 more reviewer

@paulacamargo25 paulacamargo25 paulacamargo25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthiknadig karthiknadig

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address issues reported by mypy --strict

2 participants

@karthiknadig @paulacamargo25