Skip to content

Flag 'stringLiteral' fields as special#122

Merged
karthiknadig merged 1 commit into
microsoft:mainfrom
alcarney:fix-progress
Nov 8, 2022
Merged

Flag 'stringLiteral' fields as special#122
karthiknadig merged 1 commit into
microsoft:mainfrom
alcarney:fix-progress

Conversation

@alcarney
Copy link
Copy Markdown
Contributor

@alcarney alcarney commented Nov 8, 2022

This fixes an issue where the kind field of WorkDoneProgress<Kind> types is omitted when serialising to JSON

@alcarney
Copy link
Copy Markdown
Contributor Author

alcarney commented Nov 8, 2022

@microsoft-github-policy-service agree

@karthiknadig karthiknadig self-requested a review November 8, 2022 20:25
@karthiknadig karthiknadig self-assigned this Nov 8, 2022
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Nov 8, 2022
@karthiknadig
Copy link
Copy Markdown
Member

@alcarney Can you run isort --profile black ./tests/notifications/test_progress.py?

@alcarney
Copy link
Copy Markdown
Contributor Author

alcarney commented Nov 8, 2022

Done :)

@karthiknadig karthiknadig merged commit 7b2e7ab into microsoft:main Nov 8, 2022
@alcarney alcarney deleted the fix-progress branch November 8, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants