This repository was archived by the owner on Nov 5, 2021. It is now read-only.
Adds support for TypeScript 4.3 builds #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's been more JSDoc tag updates microsoft/TypeScript#43312 |
|
This is bumped to a new change in 4.4, which is backwards compatible. This PR can be merged anytime if we want to bump the default TS version to the 4.3 stable builds |
|
👍 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/TypeScript#42890 added an extra param to the
getCompletionEntryDetailswhich fails the current build ( because we pass 6 args, not 7 ) - this isn't backwards compatible without a// @ts-ignoreso it'll probably need to wait till 4.3 is shipped to get merged.So, the red on CI is on purpose. It's still using the old TS d.ts.