Skip to content

Updated skipifs and modified tests with HGS enabled servers #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2020
Merged

Updated skipifs and modified tests with HGS enabled servers #1111

merged 2 commits into from
Apr 3, 2020

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Apr 3, 2020

In SKIPIF should not specify ODBC driver and then check if ODBC 17 is used.
Also fixed the coding style to adhere to the PSR-2 standard

@coveralls
Copy link

coveralls commented Apr 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 74.373% when pulling fc83edd on yitam:v2Tests into 7214e8d on microsoft:dev.

@yitam yitam requested a review from v-mabarw April 3, 2020 00:45
v-mabarw
v-mabarw previously approved these changes Apr 3, 2020
View reviewed changes
v-mabarw
v-mabarw approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@v-mabarw v-mabarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@yitam yitam merged commit e8fef22 into microsoft:dev Apr 3, 2020
@yitam yitam deleted the v2Tests branch April 3, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@v-mabarw v-mabarw v-mabarw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yitam @coveralls @v-mabarw