Skip to content

Add deprecation message about ODBC13 #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Add deprecation message about ODBC13 #1456

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8fa56f3
Reset type after bind param
absci May 10, 2023
b476e18
Add unit test, skip for decimal format
absci May 11, 2023
a9c3d98
Add unit test, skip for decimal format
absci May 11, 2023
74d961a
Update unit test
absci May 11, 2023
ea0220a
Add deprecation message about ODBC13
absci Jun 8, 2023
8d4c6c3
Merge branch 'dev' of github.com:microsoft/msphpsql into add_warning
absci Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/shared/core_conn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ sqlsrv_conn* core_sqlsrv_connect( _In_ sqlsrv_context& henv_cp, _In_ sqlsrv_cont
CHECK_CUSTOM_ERROR(conn->ce_option.enabled && conn->driver_version == ODBC_DRIVER::VER_13, conn, SQLSRV_ERROR_CE_DRIVER_REQUIRED, get_processor_arch(), NULL) {
throw core::CoreException();
}

if (conn->driver_version == ODBC_DRIVER::VER_13) {
zend_error(E_DEPRECATED, "ODBC driver version 13 is deprecated, please consider upgrading to the latest version.");
}
#ifndef _WIN32
// check if the ODBC driver actually exists, if not, throw an exception
CHECK_CUSTOM_ERROR(!core_search_odbc_driver_unix(conn->driver_version), conn, SQLSRV_ERROR_SPECIFIED_DRIVER_NOT_FOUND) {
Expand Down