Fixed test again #741
Merged
Fixed test again #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitam
reviewed
Apr 5, 2018
| @@ -21,7 +21,7 @@ if ($c !== false) { | |||
| ?> | |||
| --EXPECTREGEX-- | |||
|
|
|||
| Fatal error: Uncaught PDOException: SQLSTATE\[(28000|08001|HYT00)\]: .*\[Microsoft\]\[ODBC Driver 1[0-9] for SQL Server\](\[SQL Server\])?(Named Pipes Provider: Could not open a connection to SQL Server \[2\]\. |TCP Provider: Error code 0x2AF9|Login timeout expired|Login failed for user 'sa'\.) in .+(\/|\\)pdo_utf8_conn\.php:[0-9]+ | |||
| Fatal error: Uncaught PDOException: SQLSTATE\[(28000|08001|HYT00)\]: .*\[Microsoft\]\[ODBC Driver 1[0-9] for SQL Server\](\[SQL Server\])?(Named Pipes Provider: Could not open a connection to SQL Server \[2\]\. |TCP Provider: Error code 0x2726|TCP Provider: Error code 0x2AF9|Login timeout expired|Login failed for user 'sa'\.) in .+(\/|\\)pdo_utf8_conn\.php:[0-9]+ | |||
| Stack trace: | |||
There was a problem hiding this comment.
can you change the regex to TCP Provider: Error code to accept either one of the two possible codes?
There was a problem hiding this comment.
That's TCP Provider: Error code (0x2726|0x2AF9) right?
There was a problem hiding this comment.
should be, please run a quick test in your local env just in case :)
Codecov Report
@@ Coverage Diff @@
## dev #741 +/- ##
=======================================
Coverage 78.99% 78.99%
=======================================
Files 25 25
Lines 7190 7190
=======================================
Hits 5680 5680
Misses 1510 1510Continue to review full report at Codecov.
|
|
Merging because I want to run the fix tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the error code on Bamboo is different from the one tested on my mac.
This change is