Changelog for 5.2.1-preview #779

yitam · 2018-05-24T22:51:01Z

This change is

codecov-io · 2018-05-24T23:15:40Z

Codecov Report

Merging #779 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #779   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          25       25           
  Lines        7323     7323           
=======================================
  Hits         5863     5863           
  Misses       1460     1460

Impacted Files	Coverage Δ
...6/php-7.1.17-src/ext/sqlsrv/shared/core_stream.cpp
...c14/x86/php-7.1.17-src/ext/pdo_sqlsrv/pdo_util.cpp
...ev/vc14/x86/php-7.1.17-src/ext/sqlsrv/php_sqlsrv.h
...x86/php-7.1.17-src/ext/sqlsrv/shared/core_util.cpp
...x86/php-7.1.17-src/ext/sqlsrv/shared/core_init.cpp
...php-7.1.17-src/ext/pdo_sqlsrv/shared/core_util.cpp
.../php-7.1.17-src/ext/sqlsrv/shared/core_results.cpp
...p-7.1.17-src/ext/pdo_sqlsrv/shared/core_stream.cpp
...php-7.1.17-src/ext/pdo_sqlsrv/shared/core_conn.cpp
...vc14/x86/php-7.1.17-src/ext/pdo_sqlsrv/pdo_dbh.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0eefaf...c676ae0. Read the comment docs.

coveralls · 2018-05-25T19:22:34Z

Coverage remained the same at 74.697% when pulling c676ae0 on yitam:changelog into f0eefaf on Microsoft:dev.

david-puglielli · 2018-05-25T23:11:17Z

CHANGELOG.md

+### Fixed
+- Issue [#577](https://github.com/Microsoft/msphpsql/issues/577) - Idle Connection Resiliency doesn't work with Column Encryption enabled connection
+- Issue [#678](https://github.com/Microsoft/msphpsql/issues/678) - Idle Connection Resiliency doesn't work with Connection Pooling bug
+- Issue [#699](https://github.com/Microsoft/msphpsql/issues/699) - binding output parameter failed when the query in the stored procedure returned no data. The test case has been added to the test lab.


Capitalise the B

david-puglielli · 2018-05-25T23:11:35Z

CHANGELOG.md

+- Issue [#699](https://github.com/Microsoft/msphpsql/issues/699) - binding output parameter failed when the query in the stored procedure returned no data. The test case has been added to the test lab.
+- Issue [#705](https://github.com/Microsoft/msphpsql/issues/705) - AE - Retrieving a negative decimal value (edge case) as output parameter causes truncation
+- Issue [#706](https://github.com/Microsoft/msphpsql/issues/706) - AE - Cannot insert double with precision and scale (38, 38)
+- Issue [#707](https://github.com/Microsoft/msphpsql/issues/707) - AE - fetching decimals / numerics as output parameters bound to PDO::PARAM_BOOL or PDO::PARAM_INT returns floats, not integers 


Capitalise the F in fetching

david-puglielli · 2018-05-25T23:12:05Z

CHANGELOG.md

+- Issue [#705](https://github.com/Microsoft/msphpsql/issues/705) - AE - Retrieving a negative decimal value (edge case) as output parameter causes truncation
+- Issue [#706](https://github.com/Microsoft/msphpsql/issues/706) - AE - Cannot insert double with precision and scale (38, 38)
+- Issue [#707](https://github.com/Microsoft/msphpsql/issues/707) - AE - fetching decimals / numerics as output parameters bound to PDO::PARAM_BOOL or PDO::PARAM_INT returns floats, not integers 
+- Issue [#735](https://github.com/Microsoft/msphpsql/issues/735) - PDO lastInsertId primary bigInt, after id 999999999 return ''


This description is confusing - what has been changed?

david-puglielli · 2018-05-25T23:12:23Z

CHANGELOG.md

+- Issue [#707](https://github.com/Microsoft/msphpsql/issues/707) - AE - fetching decimals / numerics as output parameters bound to PDO::PARAM_BOOL or PDO::PARAM_INT returns floats, not integers 
+- Issue [#735](https://github.com/Microsoft/msphpsql/issues/735) - PDO lastInsertId primary bigInt, after id 999999999 return ''
+- Pull Request [#759](https://github.com/Microsoft/msphpsql/pull/759) - removed the limitation of binding a binary as inout param as PDO::PARAM_STR with SQLSRV_ENCODING_BINARY
+- Pull Request [#775](https://github.com/Microsoft/msphpsql/pull/775) - fixed the problem for output params with SQL types specified as SQLSRV_SQLTYPE_DECIMAL or SQLSRV_SQLTYPE_NUMERIC


Capitalise the r and f

david-puglielli · 2018-05-25T23:13:08Z

CHANGELOG.md

+- In Linux and macOS, setlocale() only takes effect if it is invoked before the first connection. Attempting to set the locale after connection will not work
+- Always Encrypted feature, which requires [MS ODBC Driver 17+](https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017)
+  - only Windows Certificate Store and Azure Key Vault are supported
+  - Issue [#716](https://github.com/Microsoft/msphpsql/issues/716) - Named Parameters in Sub Queries


Give a brief description of the limitation here?

david-puglielli · 2018-05-25T23:13:58Z

CHANGELOG.md

+- When pooling is enabled in Linux or macOS
+  - unixODBC <= 2.3.4 (Linux and macOS) might not return proper diagnostics information, such as error messages, warnings and informative messages
+  - due to this unixODBC bug, fetch large data (such as xml, binary) as streams as a workaround. See the examples [here](https://github.com/Microsoft/msphpsql/wiki/Features#pooling)
+- With ColumnEncryption enabled, calling stored procedure with XML parameter does not work (Issue [#674](https://github.com/Microsoft/msphpsql/issues/674))


....calling stored procedures with XML parameters does not.....

david-puglielli · 2018-05-25T23:14:58Z

CHANGELOG.md

+Updated PECL release packages. Here is the list of updates:
+
+### Added
+- Added support for Azure Key Vault for Always Encrypted for basic CRUD functionalities 


I think we should mention that AE now supports Linux and mac through AKV

david-puglielli · 2018-05-25T23:18:34Z

README.md

@@ -96,15 +93,9 @@ The version number may have trailing pre-release version identifiers to indicate
 ## Guidelines for Reporting Issues
 We appreciate you taking the time to test the driver, provide feedback and report any issues.  It would be extremely helpful if you:

+- First check [FAQ](https://github.com/Microsoft/msphpsql/wiki/FAQ) 


david-puglielli · 2018-05-25T23:19:25Z

README.md

-  * Table schema (for some issues, the data types make a big difference!)
-  * Any other relevant information you want to share
- Try to include a PHP script demonstrating the isolated problem.
+- Please address the questions in the new issue template and provide scripts, table schema, and/or any detail that help reproducing the problem(s)


...any details that may help reproduce the problem(s)

yitam added 7 commits May 16, 2018 11:17

Changelog for 5.2.1-preview

c56fb30

Fixed the links

ebd7827

Fixed one more link

3d51d76

Merge branch 'dev' into changelog

6eb96d9

Updated change log based on review

e2b48df

Added a couple more fixes and elaborated some comments

4c06237

Fixed some typos

8356b15

yitam added 2 commits May 25, 2018 11:59

Added High Sierra and modified the macOS instructions

997e80c

Shifted NOTES

3c405f4

david-puglielli reviewed May 25, 2018

View reviewed changes

Addressed review comments

c676ae0

david-puglielli approved these changes May 26, 2018

View reviewed changes

yitam merged commit 9e75dfe into microsoft:dev May 29, 2018

yitam deleted the changelog branch May 29, 2018 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Changelog for 5.2.1-preview #779

Changelog for 5.2.1-preview #779

Uh oh!

yitam commented May 24, 2018 •

edited by lilgreenbird

Loading

Uh oh!

codecov-io commented May 24, 2018 •

edited

Loading

Uh oh!

coveralls commented May 25, 2018 •

edited

Loading

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

david-puglielli May 25, 2018

Uh oh!

Uh oh!

Changelog for 5.2.1-preview #779

Changelog for 5.2.1-preview #779

Uh oh!

Conversation

yitam commented May 24, 2018 • edited by lilgreenbird Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented May 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented May 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yitam commented May 24, 2018 •

edited by lilgreenbird

Loading

codecov-io commented May 24, 2018 •

edited

Loading

coveralls commented May 25, 2018 •

edited

Loading