Skip to content

Modified version.h for 5.2.1-preview #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2018
Merged

Modified version.h for 5.2.1-preview #780

merged 2 commits into from
May 25, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented May 24, 2018

This change is Reviewable

@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #780 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #780   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          25       25           
  Lines        7323     7323           
=======================================
  Hits         5863     5863           
  Misses       1460     1460
Impacted Files Coverage Δ
...p-7.1.17-src/ext/pdo_sqlsrv/shared/core_stream.cpp
...x86/php-7.1.17-src/ext/sqlsrv/shared/core_stmt.cpp
...phpdev/vc14/x86/php-7.1.17-src/ext/sqlsrv/stmt.cpp
...x86/php-7.1.17-src/ext/sqlsrv/shared/core_util.cpp
...x86/php-7.1.17-src/ext/sqlsrv/shared/core_sqlsrv.h
...php-7.1.17-src/ext/pdo_sqlsrv/shared/core_util.cpp
...c14/x86/php-7.1.17-src/ext/pdo_sqlsrv/pdo_init.cpp
.../php-7.1.17-src/ext/sqlsrv/shared/core_results.cpp
...phpdev/vc14/x86/php-7.1.17-src/ext/sqlsrv/util.cpp
...phpdev/vc14/x86/php-7.1.17-src/ext/sqlsrv/init.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0eefaf...6817c7b. Read the comment docs.

@yitam yitam requested a review from david-puglielli May 25, 2018 16:41
@coveralls
Copy link

coveralls commented May 25, 2018

Coverage Status

Coverage remained the same at 74.697% when pulling d26440b on yitam:version into f0eefaf on Microsoft:dev.

#undef SEMVER_PRERELEASE
#define SEMVER_PRERELEASE "preview"
#define VER_FILEVERSION_STR VER_APIVERSION_STR "-" SEMVER_PRERELEASE SEMVER_BUILDMETA
#else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEMVER_BUILDMETA is empty unless SQLVERSION_BUILD is not 0, but when is SQLVERSION_BUILD not zero?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build scripts take care of setting the SQLVERSION_BUILD, see this line

https://github.com/Microsoft/msphpsql/blob/master/buildscripts/buildtools.py?utf8=%E2%9C%93#L269

@yitam yitam merged commit 45f422a into microsoft:dev May 25, 2018
@yitam yitam deleted the version branch May 25, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants