Skip to content

Fixed output for sqlsrv connres tests #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Fixed output for sqlsrv connres tests #818

merged 3 commits into from
Jul 20, 2018

Conversation

david-puglielli
Copy link
Contributor

@david-puglielli david-puglielli commented Jul 19, 2018

This change is Reviewable

@david-puglielli david-puglielli requested a review from yitam July 19, 2018 23:19
Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably sufficient just to check err[0][0] and err[0][2]

@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage remained the same at 75.148% when pulling 6ee8c44 on david-puglielli:connres-test-fixes into 6f0f4b7 on Microsoft:dev.

Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, do confirm these changes work by running customized in test lab - dev branch

@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #818 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #818   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          25       25           
  Lines        7325     7325           
=======================================
  Hits         5865     5865           
  Misses       1460     1460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0f4b7...6ee8c44. Read the comment docs.

@david-puglielli david-puglielli merged commit bd34cab into microsoft:dev Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants