Skip to content

Update sqlsrv_sample.php #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vaibhavsharma56
Copy link

No description provided.

@yitam
Copy link
Contributor

yitam commented Oct 29, 2018

hi @vaibhavsharma56 , thanks for your contribution, but as I mentioned in #867 and #870 , please merge to our dev branch, not master. At the next preview we will merge to master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.367% when pulling 1eb6166 on vaibhavsharma56:patch-1 into 14acf00 on Microsoft:master.

@codecov-io
Copy link

Codecov Report

Merging #871 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          25       25           
  Lines        7419     7419           
=======================================
  Hits         5949     5949           
  Misses       1470     1470
Impacted Files Coverage Δ
...php-7.1.22-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h
...x86/php-7.1.22-src/ext/sqlsrv/shared/core_util.cpp
...php-7.1.22-src/ext/pdo_sqlsrv/shared/core_init.cpp
...phpdev/vc14/x86/php-7.1.22-src/ext/sqlsrv/util.cpp
.../php-7.1.22-src/ext/sqlsrv/shared/core_results.cpp
...6/php-7.1.22-src/ext/sqlsrv/shared/core_stream.cpp
...c14/x86/php-7.1.22-src/ext/pdo_sqlsrv/pdo_util.cpp
...ev/vc14/x86/php-7.1.22-src/ext/sqlsrv/php_sqlsrv.h
...phpdev/vc14/x86/php-7.1.22-src/ext/sqlsrv/stmt.cpp
...x86/php-7.1.22-src/ext/sqlsrv/shared/core_conn.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14acf00...1eb6166. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants