-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Use env. allocators for initializers (#25108) #25281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use env. allocators for initializers (#25108) #25281
Conversation
…se_env_allocators" flag was activated (microsoft#25108)
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 5 pipeline(s). |
@tianleiwu Could you rerun the failed test, please? |
I triggered the re-run. If the error still occur, need to investigate why it happened. Error message seems showing it's related to the change:
The debug build passes because test case |
@fs-eire @tianleiwu |
You can specify a test name like
|
Thanks. I'm still working on setting up the env. to check the issue. I'm currently building with |
I remember I ever met a similar error for webgpu. The error was that it went to UMA path after the session initialization which is not expected. The UMA path should only work for the weights uploading since it's in a mapped state. The reason that I went wrongly into UMA path is that I didn't use the session's default allocator which can correctly record whether the session initialization is finished. I used a new webgpu allocator which's |
@qjia7 Thanks a lot for pointing this out! |
I see now that all c++ tests have passed, but the python tests have failed. Is there any way to debug the c++ issue when running from the onnx_backend_test_series.py? |
You can do mixed debugging using Python C++ Debugger extension for VS Code. |
Thanks, Dmitri, will try. |
Description
Pass environment allocators into the session state, if the "session.use_env_allocators" flag was activated (#25108)
Motivation and Context
Initializers use session-local allocators even if env. allocators to be used.