ci: run lintrunner on ghstack base branches; lint with editorconfig (#227)

Run on base branches too so that only new alerts are shown in a PR
review file view.

Also added editorconfig-checker linter: lint time is 1.2seconds. Total
runtime 3.5min vs before 8.5min on CI.

Renamed spellcheck etc. to Optional Lint to reflect the purposes of the
reviewdog linters

Author: justinchuby

.github/workflows/lint.yaml

@@ -4,22 +4,19 @@ on:
   push:
     branches:
       - main
+      - 'gh/**/base' # ghstack base branches
   pull_request:
 
 jobs:
-  lint-python:
-    name: Lint Python
+  optional-lint:
+    name: Optional Lint
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Setup Python
-        uses: actions/setup-python@v4.1.0
-        with:
-          python-version: "3.10"
-      - name: misspell # Check spellings as well
+      - uses: actions/checkout@v3
+      - name: misspell # Check spelling
         uses: reviewdog/action-misspell@v1
         with:
           github_token: ${{ secrets.github_token }}
@@ -39,9 +36,9 @@ jobs:
     name: Enforce style
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Setup Python
-        uses: actions/setup-python@v4.1.0
+        uses: actions/setup-python@v4
         with:
           # Version range or exact version of Python to use, using SemVer's version range syntax. Reads from .python-version if unset.
           python-version: "3.10"

.lintrunner.toml

@@ -64,6 +64,7 @@ command = [
     'run',
     'mypy_linter',
     '--config=pyproject.toml',
+    '--show-disable',
     '--',
     '@{{PATHSFILE}}'
 ]
@@ -128,6 +129,7 @@ command = [
     'run',
     'pylint_linter',
     '--rcfile=pyproject_pylint.toml',
+    '--show-disable',
     '--',
     '@{{PATHSFILE}}'
 ]
@@ -140,3 +142,28 @@ init_command = [
     '--dry-run={{DRYRUN}}',
     'pylint==2.15.5',
 ]
+
+[[linter]]
+code = 'EDITORCONFIG-CHECKER'
+include_patterns = ['**']
+exclude_patterns = [
+    '**/*.ipynb',
+]
+command = [
+    'python',
+    '-m',
+    'lintrunner_adapters',
+    'run',
+    'editorconfig_checker_linter',
+    '--',
+    '@{{PATHSFILE}}'
+]
+init_command = [
+    'python',
+    '-m',
+    'lintrunner_adapters',
+    'run',
+    'pip_init',
+    '--dry-run={{DRYRUN}}',
+    'editorconfig-checker==2.6.2',
+]

.vscode/extensions.json

@@ -2,4 +2,4 @@
     "recommendations": [
         "editorconfig.editorconfig"
     ]
-}
+}

LICENSE

@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+SOFTWARE.

MANIFEST.in

@@ -7,4 +7,4 @@ include requirements.txt
 
 # exclude from sdist
 exclude *.onnx
-prune */__pycache__
+prune */__pycache__

ROADMAP.md

@@ -28,4 +28,4 @@ Python features/constructs as early as possible and report it.
   - Improve type-annotation support, especially for tensor shapes
   - Improve support for non-tensor types (sequences, maps, and optional)
   - Improve checking in eager-mode to ensure its semantics is aligned with ONNX semantics
-  - Support for variadic inputs/outputs
+  - Support for variadic inputs/outputs

SECURITY.md

@@ -38,4 +38,4 @@ We prefer all communications to be in English.
 
 Microsoft follows the principle of [Coordinated Vulnerability Disclosure](https://www.microsoft.com/en-us/msrc/cvd).
 
-<!-- END MICROSOFT SECURITY.MD BLOCK -->
+<!-- END MICROSOFT SECURITY.MD BLOCK -->

requirements-dev.txt

@@ -22,4 +22,4 @@ torch
 
 # Lint
 lintrunner
-lintrunner_adapters
+lintrunner_adapters>=0.3