ci: run lintrunner on ghstack base branches; lint with editorconfig#227
Merged
justinchuby merged 5 commits intomainfrom Dec 5, 2022
Merged
ci: run lintrunner on ghstack base branches; lint with editorconfig#227justinchuby merged 5 commits intomainfrom
justinchuby merged 5 commits intomainfrom
Conversation
So that only new alerts are shown in a PR review file view.
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 89 89
Lines 7216 7216
=======================================
Hits 5451 5451
Misses 1765 1765 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
justinchuby
changed the title
titaiwangms
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run on base branches too so that only new alerts are shown in a PR review file view.
Also added editorconfig-checker linter: lint time is 1.2seconds. Total runtime 3.5min vs before 8.5min on CI.
Renamed spellcheck etc. to Optional Lint to reflect the purposes of the reviewdog linters
Reviewers: please merge if approved