fix(ir): update scoped_values (#2093)

Johansmm · Johansmm · commit 86643c53a0ca · 2025-03-11T08:09:50.000+01:00
Show there is a bug when deserializing NodeProto with inputs/outputs.
For deserialize to work without context, it is necessary that the first element be an empty dict.
diff --git a/onnxscript/ir/serde.py b/onnxscript/ir/serde.py
@@ -958,7 +958,7 @@ def _deserialize_attribute(
 
 def deserialize_node(proto: onnx.NodeProto) -> _core.Node:
     return _deserialize_node(
-        proto, scoped_values=[], value_info={}, quantization_annotations={}
+        proto, scoped_values=[{}], value_info={}, quantization_annotations={}
     )
 
 
diff --git a/onnxscript/ir/serde_test.py b/onnxscript/ir/serde_test.py
@@ -18,7 +18,7 @@ class ConvenienceFunctionsTest(unittest.TestCase):
         [
             ("model", onnx.ModelProto()),
             ("graph", onnx.GraphProto()),
-            ("node", onnx.NodeProto()),
+            ("node", onnx.NodeProto(input=["X"], output=["Y"])),
             (
                 "tensor",
                 onnx.helper.make_tensor("test_tensor", onnx.TensorProto.FLOAT, [1], [1.0]),

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ def _deserialize_attribute(`
`958`	`958`
`959`	`959`	`def deserialize_node(proto: onnx.NodeProto) -> _core.Node:`
`960`	`960`	`return _deserialize_node(`
`961`		`- proto, scoped_values=[], value_info={}, quantization_annotations={}`
	`961`	`+ proto, scoped_values=[{}], value_info={}, quantization_annotations={}`
`962`	`962`	`)`
`963`	`963`
`964`	`964`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class ConvenienceFunctionsTest(unittest.TestCase):`
`18`	`18`	`[`
`19`	`19`	`("model", onnx.ModelProto()),`
`20`	`20`	`("graph", onnx.GraphProto()),`
`21`		`- ("node", onnx.NodeProto()),`
	`21`	`+ ("node", onnx.NodeProto(input=["X"], output=["Y"])),`
`22`	`22`	`(`
`23`	`23`	`"tensor",`
`24`	`24`	`onnx.helper.make_tensor("test_tensor", onnx.TensorProto.FLOAT, [1], [1.0]),`