[IR] Error when parsing NodeProto

[Johansmm]

ir.from_proto raises an exception for NodeProto:

import onnxscript
import onnx

node = onnx.helper.make_node('Conv', ['X', 'W'], ['Y'])
onnxscript.ir.from_proto(node) # Error here

Error logs:

Input 'X' of node '(::Conv:)' not found in any scope. The graph may be unsorted. Creating a new input (current depth: 0) .
Traceback (most recent call last):
  File "D:\.envs\onnx\Lib\site-packages\onnxscript\ir\serde.py", line 98, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "D:\.envs\onnx\Lib\site-packages\onnxscript\ir\serde.py", line 975, in _deserialize_node
    scoped_values[-1][input_name] = value
    ~~~~~~~~~~~~~^^^^
IndexError: list index out of range

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "D:\.envs\onnx\Lib\site-packages\onnxscript\ir\serde.py", line 160, in from_proto
    return deserialize_node(proto)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\.envs\onnx\Lib\site-packages\onnxscript\ir\serde.py", line 921, in deserialize_node
    return _deserialize_node(proto, scoped_values=[], value_info={})
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\.envs\onnx\Lib\site-packages\onnxscript\ir\serde.py", line 100, in wrapper
    raise SerdeError(
onnxscript.ir.serde.SerdeError: Error calling _deserialize_node with: input: "X"
input: "W"
output: "Y"
op_type: "Conv"

[justinchuby]

Thanks for reporting. Could you share your use case for deserializing a single node proto?

[Johansmm]

@justinchuby, I am not sure if it is very frequent, but I wanted to use it to deserialize all the attributes of the node (not to do it one by one) in order to change one attribute and re-serializing the node. Something like:

node = onnx.helper.make_node('Conv', ['X', 'W'], ['Y'])
ir_node = onnxscript.ir.from_proto(node)
ir_node.attributes["dilations"] = ir.AttrInt64('dilations', [1,1])
new_node = onnxscript.ir.to_proto(ir_node)

I know this can be done with onnx.helper, but I find it easier to use onnxscript for this purpose :).

[justinchuby]

Makes sense thanks for sharing. Could you send a patch, in:

File "D:.envs\onnx\Lib\site-packages\onnxscript\ir\serde.py", line 921, in deserialize_node
return _deserialize_node(proto, scoped_values=[], value_info={})

Simply change to scoped_values=[[]]

And see if it works?

[Johansmm]

I tried with scoped_values=[[]] and does not work. However, I tried again with scoped_values=[{}] and it worked perfectly!

Full example:

import onnx
from onnxscript import ir

node = onnx.helper.make_node("Conv", ["X", "W"], ["Y"])
ir_node = ir.from_proto(node)
ir_node.attributes["dilations"] = ir.AttrInt64s("dilations", [1, 1, 1, 1])
print(ir.to_proto(ir_node))
# input: "X"
# input: "W"
# output: "Y"
# op_type: "Conv"
# attribute {
#   name: "dilations"
#   ints: 1
#   ints: 1
#   ints: 1
#   ints: 1
#   type: INTS
# }

[justinchuby]

Ah great thanks! Could you create a pr?

[Johansmm]

PR: #2098