[IR] Fix deserialize_node #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
reviewed
Mar 11, 2025
Johansmm
force-pushed
the
custom-name-in-function
branch
from
293d484 to
eebdc2a
Compare
Show there is a bug when deserializing NodeProto with inputs/outputs. For deserialize to work without context, it is necessary that the first element be an empty dict.
Johansmm
force-pushed
the
custom-name-in-function
branch
from
eebdc2a to
86643c5
Compare
|
Last push force with @justinchuby suggestion |
justinchuby
approved these changes
Mar 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
=======================================
Coverage 72.64% 72.64%
=======================================
Files 217 217
Lines 29143 29143
Branches 3463 3463
=======================================
Hits 21170 21170
Misses 6846 6846
Partials 1127 1127 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ir.from_protoraises an exception forNodeProtoinput type. Here this error is fixed.Close #2093