[Migration][DO NOT MERGE] Fix linting

ghstack-source-id: b32a886
Pull Request resolved: #1333

Author: BowenBao

.lintrunner.toml

@@ -46,6 +46,19 @@ exclude_patterns = [
     'tests/**', # Skip linting test files for speed
     'onnxscript/**/*_test.py', # Skip linting test files for speed
     'onnxscript/function_libs/torch_lib/ops/**', # Operators typing do not play well with mypy
+    'onnxscript/optimizer/evaluator.py',  # FIXME
+    'onnxscript/optimizer/constant_folding.py',  # FIXME
+    'onnxscript/_legacy_ir/__init__.py',  # FIXME
+    'onnxscript/rewriter/onnxruntime/transformers/fastgelu.py',  # FIXME
+    'onnxscript/rewriter/onnxruntime/instance_to_group_normalization.py',  # FIXME
+    'onnxscript/rewriter/function_rule.py',  # FIXME
+    'onnxscript/_legacy_ir/irbuilder.py',  # FIXME
+    'onnxscript/optimizer/fold_constants_v0.py',  # FIXME
+    'onnxscript/rewriter/pattern.py',  # FIXME
+    'onnxscript/rewriter/onnxruntime/transformers/multihead_attention.py',  # FIXME
+    'onnxscript/tools/function_unittest_producer.py',  # FIXME
+    'onnxscript/_legacy_ir/visitor.py',  # FIXME
+    'onnxscript/rewriter/onnxruntime/transformers/layernorm.py',  # FIXME
 ]
 command = [
     'python',

onnxscript/rewriter/pattern_test.py

@@ -210,8 +210,6 @@ def test_concat_in_function(self):
 
 class RewriteRuleTest(unittest.TestCase):
     def test_commute(self):
-        op = pattern.onnxop
-
         def add_0(x):
             return x + 0
 
@@ -239,8 +237,6 @@ def identity(x):
         self.assertEqual(nodes[1].op_type, "Identity")
 
     def test_const_value(self):
-        op = pattern.onnxop
-
         def reshape(x, newshape):
             return op.Reshape(x, newshape)
 
@@ -259,10 +255,7 @@ def _check_for_redundant_reshape(x, newshape):
 
             if len(oldshape) != len(newshape):
                 return False
-            for d1, d2 in zip(oldshape, newshape):
-                if d1 != d2 and d2 != -1:  # noqa: PLR1714
-                    return False
-            return True
+            return all(not (d1 != d2 and d2 != -1) for d1, d2 in zip(oldshape, newshape))
 
         def check_for_redundant_reshape(bindings):
             return _check_for_redundant_reshape(**bindings)