[Migration][DO NOT MERGE] Fix linting #1333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gh/BowenBao/25/base #1333 +/- ##
====================================================
Coverage 64.16% 64.16%
====================================================
Files 136 136
Lines 19019 19019
Branches 3120 3120
====================================================
Hits 12204 12204
Misses 6318 6318
Partials 497 497 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
[ghstack-poisoned]
Test Results 24 files 24 suites 19m 21s ⏱️ Results for commit dc7653b. ♻️ This comment has been updated with latest results. |
[ghstack-poisoned]
… linting" [ghstack-poisoned]
[ghstack-poisoned]
justinchuby
reviewed
Apr 2, 2024
| 'onnxscript/_legacy_ir/visitor.py', # FIXME | ||
| 'onnxscript/_legacy_ir/protobuilder.py', # FIXME | ||
| 'onnxscript/rewriter/onnxruntime/transformers/layernorm.py', # FIXME | ||
| 'onnxscript/ir/serde.py', # FIXME |
Contributor
Author
There was a problem hiding this comment.
some attr not defined error, because CI onnx is not 1.16
Collaborator
There was a problem hiding this comment.
Ok. Strange it wasn’t caught last time
justinchuby
approved these changes
Apr 2, 2024
Cutoff from 991f82bcc99706cd8ea6b7f2b70ccec75db2dbd6. Changes after the above commit but before the cutoff date will be migrated in follow-up within this stack. [ghstack-poisoned]
Cutoff from 991f82bcc99706cd8ea6b7f2b70ccec75db2dbd6. Changes after the above commit but before the cutoff date will be migrated in follow-up within this stack. [ghstack-poisoned]
…RGE] Fix linting" Cutoff from 991f82bcc99706cd8ea6b7f2b70ccec75db2dbd6. Changes after the above commit but before the cutoff date will be migrated in follow-up within this stack. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 4, 2024
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <[email protected]> Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: "G. Ramalingam" <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]> [ghstack-poisoned]
Merged
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com> Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com> Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com> Co-authored-by: "G. Ramalingam" <gramamicrosoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com> Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com> Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com> Co-authored-by: "G. Ramalingam" <gramamicrosoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1334 * #1340 * __->__ #1346 Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <[email protected]> Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: "G. Ramalingam" <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
Contributor
Author
|
Close as squashed and merged into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_legacy_irfolder #1332Cutoff from 991f82bcc99706cd8ea6b7f2b70ccec75db2dbd6.
Changes after the above commit but before the cutoff date will be migrated in follow-up within this stack.