[Migration][DO NOT MERGE] Fix and enable all new tests #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. [ghstack-poisoned]
This was referenced Apr 1, 2024
BowenBao
added a commit
that referenced
this pull request
Apr 1, 2024
- Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. ghstack-source-id: f9675b6 Pull Request resolved: #1331
BowenBao
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gh/BowenBao/23/base #1331 +/- ##
====================================================
Coverage 61.03% 61.03%
====================================================
Files 185 185
Lines 22112 22112
Branches 3664 3664
====================================================
Hits 13497 13497
Misses 8216 8216
Partials 399 399 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,19 +1,29 @@ | |||
| # ------------------------------------------------------------------------- | |||
Check warning
Code scanning / lintrunner
RUFF/format
| @@ -1,19 +1,29 @@ | |||
| # ------------------------------------------------------------------------- | |||
Check warning
Code scanning / lintrunner
RUFF-FORMAT/format
| @@ -1,5 +1,5 @@ | |||
| from onnxrewriter.rewriter import pattern | |||
| from onnxrewriter.rewriter.broadcast_to_matmul import check_if_need_reshape | |||
| from onnxscript.rewriter import pattern | |||
Check warning
Code scanning / lintrunner
RUFF/format
| @@ -1,5 +1,5 @@ | |||
| from onnxrewriter.rewriter import pattern | |||
| from onnxrewriter.rewriter.broadcast_to_matmul import check_if_need_reshape | |||
| from onnxscript.rewriter import pattern | |||
Check warning
Code scanning / lintrunner
RUFF-FORMAT/format
justinchuby
approved these changes
Apr 1, 2024
Test Results 24 files 24 suites 19m 47s ⏱️ Results for commit ef55796. ♻️ This comment has been updated with latest results. |
…RGE] Fix and enable all new tests" - Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". #1327 - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. [ghstack-poisoned]
…e all new tests" - Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". #1327 - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. [ghstack-poisoned]
This was referenced Apr 2, 2024
… and enable all new tests" - Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". #1327 - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. [ghstack-poisoned]
- Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". #1327 - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. [ghstack-poisoned]
…le all new tests" - Somewhat unrelated: moved "tests" folder out of "onnxscript". - Updated import paths in copied code. - Updated testdata lookup path due to relative path changes. - Discovered an issue with installing via "pip install -e .". #1327 - Fixed a few issues of code under "ir" that doesn't work under python 3.8, or onnx w/ ir_version < 10. All CI tests except for linter are expected to pass. [ghstack-poisoned]
This was referenced Apr 3, 2024
BowenBao
added a commit
that referenced
this pull request
Apr 4, 2024
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <[email protected]> Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: "G. Ramalingam" <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]> [ghstack-poisoned]
Merged
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com> Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com> Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com> Co-authored-by: "G. Ramalingam" <gramamicrosoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com> Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com> Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com> Co-authored-by: "G. Ramalingam" <gramamicrosoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1334 * #1340 * __->__ #1346 Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <[email protected]> Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: "G. Ramalingam" <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
|
Close as squashed and merged into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_legacy_irfolder #1332All CI tests except for linter are expected to pass.