Skip full model shape inference if model > 2GB | feat(optimizer) #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 64.82% 64.81% -0.01%
==========================================
Files 140 140
Lines 19972 19974 +2
Branches 3348 3349 +1
==========================================
Hits 12947 12947
- Misses 6482 6483 +1
- Partials 543 544 +1 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Apr 3, 2024
| model = onnx.shape_inference.infer_shapes( | ||
| model, check_type=True, strict_mode=True, data_prop=True | ||
| ) | ||
| if model.ByteSize() < 1024 * 1024 * 1024 * 2: |
justinchuby
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Merged
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1334 * #1340 * __->__ #1346 Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <[email protected]> Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: "G. Ramalingam" <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
BowenBao
force-pushed
the
gh/BowenBao/28/head
branch
from
263af0b to
e1339f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):