Skip to content

[Migration][DO NOT MERGE] Copy model tests and testdata #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

- Files are copied without any changes.
- Test models and data are managed by lfs.
- Test failures are expected due to incorrect import paths. Linter is expected to fail.

[ghstack-poisoned]
@BowenBao BowenBao changed the title [Migration] Copy model tests and testdata [Migration][DO NOT MERGE] Copy model tests and testdata Apr 1, 2024
@@ -0,0 +1,69 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF/I001

Import block is un-sorted or un-formatted. See https://docs.astral.sh/ruff/rules/unsorted-imports
@@ -0,0 +1,69 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF/format

Run `lintrunner -a` to apply this patch.
@@ -0,0 +1,69 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF-FORMAT/format

Run `lintrunner -a` to apply this patch.
@@ -0,0 +1,105 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF/I001

Import block is un-sorted or un-formatted. See https://docs.astral.sh/ruff/rules/unsorted-imports
np.testing.assert_allclose(
baseline_output, optimized_output, rtol=rtol, atol=atol
)
except AssertionError as e: # noqa: PERF203

Check warning

Code scanning / lintrunner

RUFF/RUF100

Unused `noqa` directive (non-enabled: `PERF203`). See https://docs.astral.sh/ruff/rules/unused-noqa
@@ -0,0 +1,105 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF/format

Run `lintrunner -a` to apply this patch.
@@ -0,0 +1,30 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF/I001

Import block is un-sorted or un-formatted. See https://docs.astral.sh/ruff/rules/unsorted-imports
@@ -0,0 +1,30 @@
from __future__ import annotations

Check warning

Code scanning / lintrunner

RUFF/format

Run `lintrunner -a` to apply this patch.
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 13.51351% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 61.04%. Comparing base (638414c) to head (883fdc5).

Files Patch % Lines
onnxscript/tests/common/common.py 0.00% 58 Missing ⚠️
onnxscript/tests/optimizer/test_models.py 26.47% 24 Missing and 1 partial ⚠️
onnxscript/tests/ir/serde_test.py 31.57% 13 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           gh/BowenBao/22/base    #1330      +/-   ##
=======================================================
- Coverage                61.26%   61.04%   -0.23%     
=======================================================
  Files                      182      185       +3     
  Lines                    22001    22112     +111     
  Branches                  3646     3664      +18     
=======================================================
+ Hits                     13480    13499      +19     
- Misses                    8123     8213      +90     
- Partials                   398      400       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 1, 2024

Test Results

     24 files  ±    0      24 suites  ±0   2h 38m 18s ⏱️ - 1m 55s
 14 233 tests +1 224  10 300 ✅ +914    3 892 💤 +307   21 ❌ +1   20 🔥 + 2 
412 082 runs  +   43  96 821 ✅ ±  0  314 209 💤 ±  0  632 ❌ +1  420 🔥 +42 

For more details on these failures and errors, see this check.

Results for commit 883fdc5. ± Comparison against base commit 638414c.

♻️ This comment has been updated with latest results.

…y model tests and testdata"

- Files are copied without any changes.
- Test models and data are managed by lfs.
- Test failures are expected due to incorrect import paths. Linter is expected to fail.

[ghstack-poisoned]
- Files are copied without any changes.
- Test models and data are managed by lfs.
- Test failures are expected due to incorrect import paths. Linter is expected to fail.

[ghstack-poisoned]
…ests and testdata"

- Files are copied without any changes.
- Test models and data are managed by lfs.
- Test failures are expected due to incorrect import paths. Linter is expected to fail.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 4, 2024
Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Xavier Dupré <[email protected]>
Co-authored-by: "G. Ramalingam" <[email protected]>
Co-authored-by: kunal-vaishnavi <[email protected]>
Co-authored-by: Ti-Tai Wang <[email protected]>

[ghstack-poisoned]
@BowenBao BowenBao mentioned this pull request Apr 4, 2024
BowenBao added a commit that referenced this pull request Apr 5, 2024
Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com>
Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com>
Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com>
Co-authored-by: "G. Ramalingam" <gramamicrosoft.com>
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com>
Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 5, 2024
Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com>
Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com>
Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com>
Co-authored-by: "G. Ramalingam" <gramamicrosoft.com>
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com>
Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #1334
* #1340
* __->__ #1346

Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare
<[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Xavier Dupré <[email protected]>
Co-authored-by: "G. Ramalingam" <[email protected]>
Co-authored-by: kunal-vaishnavi
<[email protected]>
Co-authored-by: Ti-Tai Wang <[email protected]>
@BowenBao
Copy link
Contributor Author

BowenBao commented Apr 5, 2024

Close as squashed and merged into main.

@BowenBao BowenBao closed this Apr 5, 2024
@justinchuby justinchuby deleted the gh/BowenBao/22/head branch January 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants