[Test] Hack to enable optimizer/rewriter integration into dynamo_export #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
This was referenced Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gh/BowenBao/26/base #1334 +/- ##
=======================================================
+ Coverage 64.81% 64.85% +0.03%
=======================================================
Files 140 140
Lines 19974 19978 +4
Branches 3349 3349
=======================================================
+ Hits 12947 12957 +10
Misses 6483 6483
+ Partials 544 538 -6 ☔ View full report in Codecov by Sentry. |
Test Results 17 files - 7 17 suites - 7 50m 20s ⏱️ + 30m 40s For more details on these failures, see this check. Results for commit 3288e59. ± Comparison against base commit 1a7320b. ♻️ This comment has been updated with latest results. |
justinchuby
reviewed
Apr 2, 2024
| @@ -17,11 +17,15 @@ | |||
| from typing_extensions import TypeAlias | |||
|
|
|||
| import onnxscript | |||
|
|
|||
| # Q: Don't know why vscode only recognizes this import style instead of `from onnxscript import optimizer`. | |||
There was a problem hiding this comment.
Prob because optimizer was not imported by __init__.py?
…gration into dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…er/rewriter integration into dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…er integration into dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…writer integration into dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
… optimizer/rewriter integration into dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
Merged
…tegration into dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
…dynamo_export" - To test in torchbench. - Somehow lintrunner changed unrelated files in this commit. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1334 * #1340 * __->__ #1346 Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <[email protected]> Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: "G. Ramalingam" <[email protected]> Co-authored-by: kunal-vaishnavi <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
BowenBao
added a commit
that referenced
this pull request
Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1334 * __->__ #1340
|
Closing as not needed. Test benchmark has completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):