Skip to content

[Migration][DO NOT MERGE] Support submodule functions in pattern-rewrite #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 98.80952% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.83%. Comparing base (fb3e327) to head (c0d5b19).

Files Patch % Lines
onnxscript/rewriter/pattern.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           gh/BowenBao/31/base    #1345      +/-   ##
=======================================================
+ Coverage                64.71%   64.83%   +0.12%     
=======================================================
  Files                      138      140       +2     
  Lines                    19900    19967      +67     
  Branches                  3342     3346       +4     
=======================================================
+ Hits                     12878    12946      +68     
+ Misses                    6481     6480       -1     
  Partials                   541      541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 4, 2024

Test Results

    24 files      24 suites   19m 25s ⏱️
 9 431 tests  7 375 ✅ 2 054 💤 2 ❌
22 845 runs  18 400 ✅ 4 443 💤 2 ❌

For more details on these failures, see this check.

Results for commit c0d5b19.

BowenBao added a commit that referenced this pull request Apr 4, 2024
Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Xavier Dupré <[email protected]>
Co-authored-by: "G. Ramalingam" <[email protected]>
Co-authored-by: kunal-vaishnavi <[email protected]>
Co-authored-by: Ti-Tai Wang <[email protected]>

[ghstack-poisoned]
@BowenBao BowenBao mentioned this pull request Apr 4, 2024
BowenBao added a commit that referenced this pull request Apr 5, 2024
Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com>
Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com>
Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com>
Co-authored-by: "G. Ramalingam" <gramamicrosoft.com>
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com>
Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 5, 2024
Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com>
Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com>
Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com>
Co-authored-by: "G. Ramalingam" <gramamicrosoft.com>
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com>
Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 5, 2024
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #1334
* #1340
* __->__ #1346

Squashed of the following steps:
- #1328
- #1329
- #1330
- #1331
- #1332
- #1333
- #1343
- #1345

Co-authored-by: Shubham Bhokare
<[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Xavier Dupré <[email protected]>
Co-authored-by: "G. Ramalingam" <[email protected]>
Co-authored-by: kunal-vaishnavi
<[email protected]>
Co-authored-by: Ti-Tai Wang <[email protected]>
@BowenBao
Copy link
Contributor Author

BowenBao commented Apr 5, 2024

Close as squashed and merged into main.

@BowenBao BowenBao closed this Apr 5, 2024
@justinchuby justinchuby deleted the gh/BowenBao/31/head branch January 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant