Skip to content

Onnx to onnxscript conversion errors #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gramalingam opened this issue Nov 18, 2023 · 2 comments
Open

Onnx to onnxscript conversion errors #1167

gramalingam opened this issue Nov 18, 2023 · 2 comments

Comments

@gramalingam
Copy link
Collaborator

gramalingam commented Nov 18, 2023 •
edited
Loading

A few different issues show up when converting the model below back to onnxscript:

The issues relate to:

  • name conflicts between attribute-parameters and corresponding values (obtained by promotion from attribute-parameter).
  • Some misalignment of loop-carried dependences for the loop operator (looks like they are off-by-one).
@justinchuby
Copy link
Collaborator

The onnx file can be zipped

@gramalingam
Copy link
Collaborator Author

stft.zip
Model attached

@gramalingam gramalingam mentioned this issue Nov 20, 2023
Merged
xiaowuhu pushed a commit that referenced this issue Nov 27, 2023
@gramalingam
Eliminate use of template in exporter (#1168)
b7f215e 
Some cleanup of the exporter before fixing issue
#1167. This eliminates the
use of template in the exporter (which was harder to understand, in
particular to debug).

---------

Signed-off-by: Ganesan Ramalingam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gramalingam @justinchuby