Skip to content

Create function boundaries for each traced functions. #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #1095
justinchuby opened this issue Dec 12, 2023 · 0 comments
Open
Tracked by #1095

Create function boundaries for each traced functions. #1218

justinchuby opened this issue Dec 12, 2023 · 0 comments
Labels
contribution welcome We welcome code contributions for this module: torchlib Related to the torch/aten function lib in development

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Dec 12, 2023 •
edited
Loading

Currently the traced functions are displayed in the graph as a flat sub-graph. We would like to preserve the function boundaries to preserve the model semantics.
@justinchuby justinchuby mentioned this issue Dec 12, 2023
Closed
5 tasks
@justinchuby justinchuby added module: torchlib Related to the torch/aten function lib in development contribution welcome We welcome code contributions for this labels Dec 12, 2023
@justinchuby justinchuby mentioned this issue Dec 12, 2023
Open
@justinchuby justinchuby mentioned this issue Mar 14, 2024
Merged
justinchuby added a commit that referenced this issue May 24, 2024
@justinchuby
Turn on TORCHLIB_EXPERIMENTAL_PREFER_TRACING (#1304)
19f4e26 
This is a BC breaking change. The flag
`TORCHLIB_EXPERIMENTAL_PREFER_TRACING` allows most functions with
control flows to be traced by default. This will eliminate some aten
functions from the graph. We will recreate these functions with
#1218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome We welcome code contributions for this module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinchuby