Skip to content

Fix tests for onnx 1.13 #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby opened this issue Dec 12, 2022 · 0 comments · Fixed by #307
Closed

Fix tests for onnx 1.13 #249

justinchuby opened this issue Dec 12, 2022 · 0 comments · Fixed by #307
Assignees
@gramalingam
Labels
fixme Tracking issues for TODOs and FIXMEs

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Dec 12, 2022 •
edited
Loading

ONNX 1.13 produced some errors in tests: https://github.com/microsoft/onnx-script/actions/runs/3678076190/jobs/6220897226

E           onnx.onnx_cpp2py_export.checker.ValidationError: Field 'type' of 'value_info' is required but missing.
@justinchuby justinchuby added the fixme Tracking issues for TODOs and FIXMEs label Dec 12, 2022
justinchuby added a commit that referenced this issue Dec 12, 2022
@justinchuby
ci: Pin onnx version to 1.12
363c8a0 
Need to fix #249 for supporting onnx 1.13
@justinchuby justinchuby mentioned this issue Dec 12, 2022
Merged
justinchuby added a commit that referenced this issue Dec 12, 2022
@justinchuby
ci: pin onnx version to 1.12; fix ci errors (#250)
d36348c 
- Pin onnx version to 1.12; Need fixing #249 for supporting onnx 1.13
- Fix new mypy errors and adjusted mypy config
@BowenBao BowenBao mentioned this issue Jan 11, 2023
Merged
justinchuby pushed a commit that referenced this issue Jan 11, 2023
@BowenBao
Fix onnxfs2_test regression for onnx 1.13 (#307)
91701fa 
Root cause is new "Reduce ops" spec promotes `axes` from attributes to
inputs, resulting in onnx test cases having more inputs than expected by
these onnx-script tests. This PR updates these onnx-script test
functions to match the signature of the updated onnx test cases.

However, since onnx test cases are not versioned, I feel tests like this
that seemingly want to represent ~~older opset~~ onnx operator with
function should not depend on it.

Fixes #249 
Fixes #298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gramalingam gramalingam

Labels
fixme Tracking issues for TODOs and FIXMEs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix onnxfs2_test regression for onnx 1.13 BowenBao/onnx-script
2 participants
@gramalingam @justinchuby