Skip to content

atenlib: Test only float inputs #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby opened this issue Dec 24, 2022 · 0 comments · Fixed by #266
Closed

atenlib: Test only float inputs #263

justinchuby opened this issue Dec 24, 2022 · 0 comments · Fixed by #266
Labels
module: torchlib Related to the torch/aten function lib in development

Comments

@justinchuby
Copy link
Collaborator

Functions can be tested on only float inputs to simplify the tests. Other dtypes can be tested on the generated symbolic functions, where all dtypes are expected to be supported.
@justinchuby justinchuby self-assigned this Dec 24, 2022
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Dec 24, 2022
@justinchuby justinchuby mentioned this issue Jan 2, 2023
Merged
xiaowuhu pushed a commit that referenced this issue Jan 4, 2023
@justinchuby
feat(atenlib): ops 5/n (#266)
040c811 
Boolean and bitwise operators, sign, leaky relu, relu, remainder etc.

- Boolean and bitwise operators will be tested with the generated
symbolic functions.
- Define more types
- Removed tests other than float. Fixes #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(atenlib): ops 5/n
1 participant
@justinchuby