Skip to content

Diagnostics / torchlib implementation consideration #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinchuby opened this issue Apr 29, 2023 · 0 comments
Open

Diagnostics / torchlib implementation consideration #702

justinchuby opened this issue Apr 29, 2023 · 0 comments
Labels
module: torchlib Related to the torch/aten function lib in development topic diagnostics topic: documentation Improvements or additions to documentation

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Apr 29, 2023

  1. I would avoid modifying any function signatures (e.g. adding a context parameter to torchlib functions etc.) This is because we want to preserve a natural function calling experience for users, where one can call a torchlib function the same way they would call an ATen op. We also want to ensure the function signature written is what gets generated in the ONNX graph.
    • We can consider having a call hook etc. that handles any context before and/or after going into a torchlib function (trace_only or not)
    • Related: roles of a function
  2. I would also try to reduce the scope of the change needed, for us to preserve a more natural authoring experience. For example, if it is possible to change just the torch_op decorator or the OnnxFunction class or an evaluator, then I would avoid adding a new decorator to all existing torchlib functions.

cc @fatcat-z @xiaowuhu @BowenBao

@justinchuby justinchuby added topic: documentation Improvements or additions to documentation module: torchlib Related to the torch/aten function lib in development topic diagnostics labels Apr 29, 2023
@justinchuby justinchuby self-assigned this Apr 29, 2023
@justinchuby justinchuby changed the title Diagnostics / torchlib integration implementation consideration Diagnostics / torchlib implementation consideration Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development topic diagnostics topic: documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

1 participant