Skip to content

op.While cannot be inside op.If #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xiaowuhu opened this issue Jul 17, 2023 · 1 comment
Closed

op.While cannot be inside op.If #879

xiaowuhu opened this issue Jul 17, 2023 · 1 comment
Labels
bug Something isn't working topic: ux User experience related topics

Comments

@xiaowuhu
Copy link
Contributor

xiaowuhu commented Jul 17, 2023 •
edited by justinchuby
Loading

If the script looks like:

cond = ...
while cond:
   ...

It works well. But if the script looks like:

cond1 = ...
if cond1:
    cond2 = ...
    while cond2:
        ....

It cannot pass the stmt checking for the op.While().

cc @gramalingam
@justinchuby justinchuby added bug Something isn't working topic: ux User experience related topics labels Jul 18, 2023
This was referenced Jul 26, 2023
Merged
Merged
gramalingam added a commit that referenced this issue Jul 27, 2023
@gramalingam
Handle loops in analysis of assigned vars (#925)
4e7e421 
The analysis function "assigned_vars" was not handling loops. Fix this.

Should fix issue #879

See also PR #909
@gramalingam
Copy link
Collaborator

I think this should work now? I will close it. Please reopen if there is any issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working topic: ux User experience related topics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gramalingam @justinchuby @xiaowuhu