Add Op(multinomial) | torchlib(feat) #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titaiwangms
added
the
module: torchlib
Open
Codecov Report
@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
+ Coverage 77.62% 77.66% +0.04%
==========================================
Files 114 114
Lines 14428 14436 +8
Branches 1543 1545 +2
==========================================
+ Hits 11200 11212 +12
+ Misses 2862 2858 -4
Partials 366 366
|
justinchuby
reviewed
Aug 29, 2023
justinchuby
reviewed
Aug 29, 2023
…g/onnx-script into titaiwang/aten_multinomail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. xfail reason: ONNX spec expects the first dim is batch size, and the whole input should be 2D.2. extra opinfo reason: We would like to have a pure 2D datasets to make sure the op is functional.ATen supports 1D and 2D, but ONNX only supports 2D, so Unsqueeze would be used when it's 1D input.