Merged
Conversation
Collaborator
|
The current looks good |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
+ Coverage 78.62% 78.63% +0.01%
==========================================
Files 118 118
Lines 15312 15312
Branches 1660 1660
==========================================
+ Hits 12039 12041 +2
+ Misses 2887 2884 -3
- Partials 386 387 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Could you sign the CLA? Thanks |
Contributor
Author
|
@microsoft-github-policy-service agree |
justinchuby
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry to add "complex logic in setup.py".
Though it's a development feature
closes #1155
I'm specifying
urlsince it's not allowed in pyproject.toml: pypa/packaging-problems#606