Fix failing tests with PyTorch nightly | fix(torchlib)#1185
Merged
justinchuby merged 5 commits intomainfrom Nov 27, 2023
Merged
Fix failing tests with PyTorch nightly | fix(torchlib)#1185justinchuby merged 5 commits intomainfrom
justinchuby merged 5 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1185 +/- ##
==========================================
+ Coverage 78.50% 78.63% +0.13%
==========================================
Files 118 118
Lines 15320 15323 +3
Branches 2388 2388
==========================================
+ Hits 12027 12050 +23
+ Misses 2903 2878 -25
- Partials 390 395 +5 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 1h 42m 52s ⏱️ + 19m 8s For more details on these failures, see this check. Results for commit c10e88f. ± Comparison against base commit 72b771c. This pull request removes 5 and adds 84 tests. Note that renamed tests count towards both.This pull request removes 2 skipped tests and adds 43 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
BowenBao
approved these changes
Nov 27, 2023
Contributor
BowenBao
left a comment
BowenBao
left a comment
There was a problem hiding this comment.
Changes LG, CI not green yet tho
Collaborator
Author
|
Yes there are still a few but my vpn isn't working :( |
justinchuby
added
the
module: torchlib
Contributor
|
win pipelines are also expected to be green? |
Collaborator
Author
|
Yes. There are some other issues happening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to fix #1061. All pipelines should now be green.